feat: add method to check pvc exists #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garomonegro
reviewed
Nov 5, 2024
garomonegro
reviewed
Nov 5, 2024
|
Could you run |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #167 +/- ##
==========================================
- Coverage 46.02% 44.86% -1.16%
==========================================
Files 19 19
Lines 1888 2309 +421
==========================================
+ Hits 869 1036 +167
- Misses 903 1155 +252
- Partials 116 118 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…eikoproj#161) * build: go 1.21, godog 0.14.1, api, apimachinery & client-go v0.28.12 * ci: building examples * ci(examples): check-dirty-repo * test(UT): fixing getIngressWithHostname * test(UT): fixing TestGetInstanceGroupList * refactor: replace 'err == wait.ErrWaitTimeout' with 'wait.Interrupted(err)' * chore: adding missed space Signed-off-by: sbhat14 <[email protected]>
Signed-off-by: sbhat14 <[email protected]>
Signed-off-by: sbhat14 <[email protected]>
garomonegro
reviewed
Nov 7, 2024
Signed-off-by: sbhat14 <[email protected]>
garomonegro
approved these changes
Nov 9, 2024
Signed-off-by: sbhat14 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: add method to check pvc exists with given status in the given namespace