Fix / as shortcut key in Firefox, prevent arrow shortcuts from triggering browser behaviors #40
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/
in firefox is a Find in Page shortcut, which revoked focus from thepage. And at least for me, Arrows + cmd + shift was triggering scroll
behaviors in a Tree Tab extension I run (tabs as a list to the side).
Since that and other behaviors are hard to predict, I think it's best to
always preventDefault() once it's clear that a known shortcut is going
to be triggered.
This should also fix #37 ! This behavior was one of the first I encountered upon playing around with the app 😢
Thanks for making a cool Tracker app! I plan to use it for some JS13k experiments 😎