Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tsconfig conflicts with build #197

Open
ph-fritsche opened this issue Mar 19, 2021 · 1 comment
Open

tsconfig conflicts with build #197

ph-fritsche opened this issue Mar 19, 2021 · 1 comment

Comments

@ph-fritsche
Copy link

shared-tsconfig allow importing modules from src per module name.

kcd-scripts/shared-tsconfig.json

Line 13 in 5c69945

"baseUrl": "../../src",

The IDE picks this up and suggests using non-relative imports.

kcd-scripts build does not support the import from baseUrl and resulting build is corrupt.

Suggested solution:

Remove the baseURL.
@kentcdodds
Copy link
Owner

Agreed! It's a poor choice as a default.

@ph-fritsche ph-fritsche mentioned this issue Mar 24, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kentcdodds @ph-fritsche