From 47eb836f3048b6e2a5020df045a15fd834d42284 Mon Sep 17 00:00:00 2001 From: Alex Krolick Date: Mon, 3 Sep 2018 12:56:33 -0700 Subject: [PATCH 1/3] add format check to validate Fixes #64 --- src/scripts/validate.js | 1 + 1 file changed, 1 insertion(+) diff --git a/src/scripts/validate.js b/src/scripts/validate.js index 6061c07b..9a8dc6c1 100644 --- a/src/scripts/validate.js +++ b/src/scripts/validate.js @@ -18,6 +18,7 @@ const useDefaultScripts = typeof validateScripts !== 'string' const scripts = useDefaultScripts ? { build: ifScript('build', 'npm run build --silent'), + format: precommit ? null : ifScript('format', 'npm run format --list-different'), lint: precommit ? null : ifScript('lint', 'npm run lint --silent'), test: precommit ? null From 1e5bc9f897a33e52b47dd81f249702c2068c7bb7 Mon Sep 17 00:00:00 2001 From: Alex Krolick Date: Mon, 3 Sep 2018 19:05:37 -0700 Subject: [PATCH 2/3] add -- to pass args to format --- src/scripts/validate.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/scripts/validate.js b/src/scripts/validate.js index 9a8dc6c1..0856a1c2 100644 --- a/src/scripts/validate.js +++ b/src/scripts/validate.js @@ -18,7 +18,7 @@ const useDefaultScripts = typeof validateScripts !== 'string' const scripts = useDefaultScripts ? { build: ifScript('build', 'npm run build --silent'), - format: precommit ? null : ifScript('format', 'npm run format --list-different'), + format: precommit ? null : ifScript('format', 'npm run format --silent -- --list-different'), lint: precommit ? null : ifScript('lint', 'npm run lint --silent'), test: precommit ? null From 0073dc75fbae880be232f4d2b8953f81af2612bb Mon Sep 17 00:00:00 2001 From: Alex Krolick Date: Mon, 3 Sep 2018 20:32:04 -0700 Subject: [PATCH 3/3] debug: remove --silent --- src/scripts/validate.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/scripts/validate.js b/src/scripts/validate.js index 0856a1c2..50a80724 100644 --- a/src/scripts/validate.js +++ b/src/scripts/validate.js @@ -18,7 +18,7 @@ const useDefaultScripts = typeof validateScripts !== 'string' const scripts = useDefaultScripts ? { build: ifScript('build', 'npm run build --silent'), - format: precommit ? null : ifScript('format', 'npm run format --silent -- --list-different'), + format: precommit ? null : ifScript('format', 'npm run format -- --list-different'), lint: precommit ? null : ifScript('lint', 'npm run lint --silent'), test: precommit ? null