Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.NET Standard 2.0 #131

Open
breyed opened this issue Apr 9, 2018 · 11 comments
Open

.NET Standard 2.0 #131

breyed opened this issue Apr 9, 2018 · 11 comments

Comments

@breyed
Copy link

breyed commented Apr 9, 2018

Currently, adding the WebSocket4Net NuGet package to a project running on the .NET Framework causes several System.*.dll files to be created in the output directory. These files are redundant with the similar files in the GAC. They are slower because they must be deployed, are not pre-jitted, and are not likely to be already loaded into memory by another process.

Updating the DLL and NuGet package to target .NET Standard 2.0 would avoid these problems. The package would continue to work on downlevel platforms, such as .NET 4.5, as long as no dependencies on features specific to later releases are introduced.

@kerryjiang
Copy link
Owner

Great, I'll work on it.

@kerryjiang
Copy link
Owner

kerryjiang commented Apr 10, 2018

Which version of .NET Framework do you use?

I don't have this problem if I set .NET 4.6 as my project's target.

Probably multiple targets cause this problem?

@breyed
Copy link
Author

breyed commented Apr 10, 2018

I'm using a new-style project (initial element is <Project Sdk="Microsoft.NET.Sdk">), with <TargetFramework>net46</TargetFramework>. It references WebSocket4Net with this:

<PackageReference Include="WebSocket4Net" Version="0.15.2" />

Some of the other assemblies that the project depends on (not related to WebSocket4Net) have <TargetFrameworks>netstandard2.0;net46</TargetFrameworks>.

@wollkopf
Copy link

Any updates on this topic?

@lorenzo93
Copy link

Me too following the topic.
Can't wait to see the support for .NET Standard 2.0!

@yiev
Copy link

yiev commented May 8, 2019

Any updates on this?

@kerryjiang
Copy link
Owner

It is on the way:
https://github.com/kerryjiang/SuperSocket/tree/master/src/SuperSocket.WebSocket

WebSocket4Net should be base on SuperSocket.WebSocket. That means server side and client side share the same protocol implementation.

@sasaman91
Copy link

Any update on supporting Net Standard 2.0?
I want to include it in my Core 2.2 project

@kerryjiang
Copy link
Owner

Actually there is already a .net core version in NuGet:
https://www.nuget.org/packages/WebSocket4Net/0.15.2

Which targets .netstandard 1.3 which is compatible with .NET Core 2.2 and .net standard 2.0.

The one I mentioned base on SuperSocket.WebSocket is a complete brand new implementation.

@sasaman91
Copy link

Net Core 2.0 and 2.2 are only compatible with Net standard 2.0.

This project targets Net Standard 1.3 only, it's only compatible with Net core 1.0

Correct me if I wrong.

https://docs.microsoft.com/en-us/dotnet/standard/net-standard

@kerryjiang
Copy link
Owner

kerryjiang commented Oct 28, 2019

I don't think so.
The project targets high standard can reference the libraries which target to lower .netstandard.

.NET implementation support
The following table lists the minimum platform versions that support each .NET Standard version. That means that later versions of a listed platform also support the corresponding .NET Standard version. For example, .NET Core 2.2 supports .NET Standard 2.0 and earlier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants