-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KeyError: (<VictronSensor.EXTERNAL_DEVICE_LOAD: 'external_device_load'>, <Units.ELECTRIC_CURRENT_AMPERE: 'A'>) #123
Comments
Seems superficially similar to #90 (comment) - which doesn't seem to have been patched? Also seems superficially similar to #99 (comment). I've already left comments on #101 before saying that it fixed the issue for me. Sadly that doesn't seem to have been merged yet. I guess I'm re-patching the patch I previously patched.. |
Fixes keshavdv#123 Alternative to keshavdv#99
Now that I've fixed the bug, I understand what debug logs are useful for it, so...
For comparison, this is the logging output after #124 is applied.
|
…'external_device_load'>, <Units.ELECTRIC_CURRENT_AMPERE: 'A'>) keshavdv#123 Rather than fixing the problem, this aims to robustify the code by handling failed lookups - not perfectly, but well enough to move on with, rather than simply failing to record anything at all into HomeAssistant. It's probably overkill - I was trying to add in debug logs, and in hindsight, they aren't useful. Just adding the default description under line 169 and changing line 178 to use that default is probably sufficient.
…'external_device_load'>, <Units.ELECTRIC_CURRENT_AMPERE: 'A'>) keshavdv#123 Rather than fixing the problem, this aims to robustify the code by handling failed lookups - not perfectly, but well enough to move on with, rather than simply failing to record anything at all into HomeAssistant. It's probably overkill - I was trying to add in debug logs, and in hindsight, they aren't useful. Just adding the default description under line 169 and changing line 178 to use that default is probably sufficient.
Version of the custom_component
Plugin reports 0.1.1 - I'm not sure if that's meaningful though.
HACS reports a8eee which matches the most recent commit here.
Configuration
I'm not sure what is being requested here
Describe the bug
Debug log
Will come back and add these later if needed.
The text was updated successfully, but these errors were encountered: