Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(developer): resolve external dependencies xml2js and restructure that are currently based on github refs #8616

Closed
mcdurdin opened this issue Apr 18, 2023 · 5 comments · Fixed by #11657 or #11660
Closed

chore(developer): resolve external dependencies xml2js and restructure that are currently based on github refs #8616

mcdurdin opened this issue Apr 18, 2023 · 5 comments · Fixed by #11657 or #11660
Assignees
@mcdurdin
Labels
chore developer/compilers/ developer/
Milestone
A18S3

Comments

@mcdurdin
Copy link
Member 

npm WARN skipping integrity check for git dependency ssh://[email protected]/keymanapp/dependency-node-xml2js.git 
npm WARN skipping integrity check for git dependency ssh://[email protected]/keymanapp/dependency-restructure.git

This is for kmc and its submodules. May need to submit patches upstream if these forks have diverged?
@mcdurdin mcdurdin added this to the 17.0 milestone Apr 18, 2023
@mcdurdin
Copy link
Member Author

mcdurdin commented May 9, 2023 •
edited
Loading

@mcdurdin
Copy link
Member Author

mcdurdin commented May 9, 2023

@srl295 any thoughts on how we can progress these?

@mcdurdin
Copy link
Member Author

mcdurdin commented Jun 8, 2023

Note, see also keymanapp/dependency-restructure#2 which adds a stub .d.ts to avoid breaking builds.

@mcdurdin mcdurdin modified the milestones: 17.0, Waiting-external Jul 11, 2023
@mcdurdin
Copy link
Member Author

Consider moving from xml2js to https://www.npmjs.com/package/fast-xml-parser?

@mcdurdin mcdurdin modified the milestones: Waiting-external, A17S17 Jul 11, 2023
@mcdurdin mcdurdin modified the milestones: A17S17, A17S18 Jul 24, 2023
@mcdurdin mcdurdin modified the milestones: A17S18, A17S19, A17S23 Aug 6, 2023
@mcdurdin mcdurdin modified the milestones: A17S23, 18.0 Oct 4, 2023
@mcdurdin
Copy link
Member Author

mcdurdin commented Oct 4, 2023

These are quite stalled. We will revisit in 18.0, perhaps move to alternate dependencies.

@mcdurdin mcdurdin mentioned this issue Feb 5, 2024
Open
@mcdurdin mcdurdin modified the milestones: 18.0, A18S5 Apr 29, 2024
@mcdurdin mcdurdin self-assigned this Apr 29, 2024
mcdurdin added a commit that referenced this issue Jun 3, 2024
@mcdurdin
chore: replace git dep on restructure with 3.0.1 in npm
b874de2 
3.0.1 includes our fix. However, 3.0.2 does not yet appear to have been
published, which has a patch for our fix?

Fixes: #8616
@mcdurdin mcdurdin mentioned this issue Jun 3, 2024
Merged
mcdurdin added a commit that referenced this issue Jun 3, 2024
@mcdurdin
chore: move xml2js into the repo to eliminate npm git dependency
e6d59fc 
Small rewrites to the xml2js code as ES6 modules. Based on
https://github.com/keymanapp/dependency-node-xml2js

Fixes: #8616
@mcdurdin mcdurdin mentioned this issue Jun 3, 2024
Merged
@keymanapp-test-bot keymanapp-test-bot bot modified the milestones: A18S5, A18S3 Jun 6, 2024
@jahorton jahorton mentioned this issue Jun 10, 2024
Closed
@mcdurdin mcdurdin mentioned this issue Aug 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mcdurdin mcdurdin

Labels
chore developer/compilers/ developer/
Projects
None yet
Milestone
A18S3
1 participant
@mcdurdin