Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit test session deregistration #232

Open
ecton opened this issue Mar 27, 2022 · 0 comments
Open

Unit test session deregistration #232

ecton opened this issue Mar 27, 2022 · 0 comments
Labels
enhancement New feature or request multiuser Issues impacting multi-user support
Milestone

Comments

@ecton
Copy link
Member

ecton commented Mar 27, 2022

In 062b590, I added authenticated session deregistration from the Client. I've manually verified things are working correctly currently, but unit tests should be written.

For local sessions, we might need to add APIs to query what sessions are authenticated. This could be a good public API to add to StorageConnection.

For client sessions, it can be tested today if you have a reference to the server by getting the ConnectedClient instance, and asking for the session by id after dropping the remaining authenticated client. However, if we go the route of adding a public API to enumerate authenticated sessions, we wouldn't need to special-case this unit test on a per-platform basis.

@ecton ecton added the enhancement New feature or request label Mar 27, 2022
@ecton ecton added this to the v1.0 milestone Mar 27, 2022
@ecton ecton moved this to Todo in Beta Roadmap Mar 27, 2022
@ecton ecton added the multiuser Issues impacting multi-user support label Mar 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request multiuser Issues impacting multi-user support
Projects
Status: Todo
Development

No branches or pull requests

1 participant