Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

permalink broken #11

Open
kvlahromei opened this issue Feb 18, 2015 · 2 comments
Open

permalink broken #11

kvlahromei opened this issue Feb 18, 2015 · 2 comments

Comments

@kvlahromei
Copy link

Hi, thanks for your map, it really rocks :-)

BTW, the leaflet permalink feature seems to be broken, as it just contains
http://osmcamera.tk/#%22
Instead it needs to contain lat, lon and zoom

harry-wood added a commit to harry-wood/osmcamera that referenced this issue May 7, 2015
Minor syntax wrongness which might be causing khris78#11 brokenness in some browsers
@harry-wood
Copy link
Contributor

For me the permalink works in safari and chrome, so I didn't reproduce the problem, however I did notice the URL gets generated with a spurious '#"' on the end, and sure enough digging in the code I saw an unclosed " which I've fixed in the above pull request. I imagine if that gets deployed, it might solve the issue in whichever browser @kvlahromei is testing with

@kvlahromei
Copy link
Author

@harry-wood Thanks for the analysis+fix This is Firefox 37 on Win 7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants