Please do not bundle oauth2-auto

[tarsius]

If at all possible, a repository used to maintain an Emacs package should not bundle any third-party libraries.

Bundling external dependencies might not cause any issues for users who install the package from Melpa, because packages distributed there can filter out unwanted libraries. But some people (including myself) run packages directly from their repositories (e.g., because that makes it much easier to contribute).

For such users the bundled library may end up on the load-path, possibly before the independently installed (or built-in) upstream version. As a result some outdated version can end up being loaded and that can be very confusing and hard to debug.

I recommend that you never bundle any third-party libraries. If that is not possible, I recommend that you put those libraries in a separate directory, alongside a file named .nosearch. The existence of this file instructs some tools (such as normal-top-level-add-subdirs-to-load-path and the tools that I use to maintain the Emacsmirror) to ignore the containing directory.

Thanks for considering this!

_{I have written similar messages many many times so I now use a template. I try to adjust it to match each individual case but it might still not apply 100% in all cases.}

[tarsius]

Friendly ping!