Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Readme (Issue #213) #226

Merged
merged 6 commits into from
Feb 13, 2024
Merged

Fix Readme (Issue #213) #226

merged 6 commits into from
Feb 13, 2024

Conversation

malleyeno
Copy link

This PR fixes issue #213 by updating the readme file with the changes made to get around the new Oauth2-auto method being used for authentication. It also has some items from the discussion has in that issue, including:

  • snippets for regular syncing
  • org-capture-template snippet with details on which parts need to be edited
  • Context around how users of the old OOB flow will have to migrate before Jan 31, since that's when Google is pulling the plug
  • Potential fix steps for an issue with PLSTORE and oauth2-auto.plist not saving its buffer properly.
  • A note on org-gcal-sync that the command does not post newly created events up, as that is handled by org-gcal-post-at-point.

Issues
I noticed while reviewing the change log that git generated that there are over 800 changes in this PR. I believe this may be due to how it got separated into line breaks within paragraphs when I tried to fork from master in Magit, since I know I did not edit the entire readme file (though I don't know if it was like that originally).

If this is an issue preventing merge, I would appreciate support in figuring out how to get just the relevant edits made.

@aspiers
Copy link

aspiers commented Jun 4, 2023

@malleyeno If I view the diff with the option to ignore whitespace enabled then it looks correct, so you probably just need to remove the changes to the EOL characters or whatever is causing these whitespace differences.

@telotortium
Copy link
Collaborator

telotortium commented Jun 5, 2023

@malleyeno Please fix the diff before I review the changes. Also, please rebase on latest master.

@malleyeno
Copy link
Author

@telotortium Should be good now! Turns out that it was a CRLF issue. I just switched over to LF.

There were additions to the readme about asymmetrical keys that were reported as conflicts. I kept both in there just in case one ends up working for the user over the other.

@licht1stein
Copy link

Updating readme is a very good idea :)

@marcelruland
Copy link

marcelruland commented Feb 13, 2024

I just set up org-gcal using this readme after I got properly confused by the one on main. This PR should be reviewed/merged.

@telotortium telotortium merged commit c954d3b into kidd:master Feb 13, 2024
@telotortium
Copy link
Collaborator

@marcelruland merged - sorry for leaving this unmerged.

@malleyeno malleyeno deleted the readme_fix_#213 branch February 14, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants