Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JBPM-10224] Missing index 'IDX_EventTypes_IdElement' with hibernate #2395

Merged
merged 3 commits into from
Mar 26, 2024

Conversation

danielemams
Copy link
Contributor

Missing index 'IDX_EventTypes_IdElement' with hibernate.hbm2ddl.auto=update

JIRA: JBPM-10224

Copy link
Member

@elguardian elguardian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All scripts should be align, not just mysql. Otherwise database certification matrix won't pass.

Copy link
Contributor Author

@danielemams danielemams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @elguardian,

ALL DBMS scripts were already aligned, except for mysql and mysqlinnodb.
For this reason in this commit you see only mysql and mysqlinnodb diff.

Let me know if this is fine for you, and let me know also for comment:
https://github.com/kiegroup/jbpm/pull/2395/files/766f28296ae25c7b4c89e77bdc1ba11a170bdbb6#r1516577455

Thank you,
Daniele Mammarella

@gmunozfe
Copy link
Member

jenkins test this

@mareknovotny
Copy link
Member

ok to test

Copy link

sonarcloud bot commented Mar 15, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@gmunozfe gmunozfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for your contribution @danielemams , well done!

@mareknovotny
Copy link
Member

jenkins do fdb

@gmunozfe gmunozfe added backport-7.67.x Generate backport PR for 7.67.x branch backport-7.67.x-blue Generate backport PR for 7.67.x-blue branch labels Mar 18, 2024
@danielemams
Copy link
Contributor Author

Hi,
this PR is still pending, I think waiting @mareknovotny that needs to approve it.
Thank you,
Daniele Mammarella

@mareknovotny mareknovotny merged commit 1558f0d into kiegroup:main Mar 26, 2024
7 of 9 checks passed
github-actions bot pushed a commit that referenced this pull request Mar 26, 2024
…2395)

* [JBPM-10224] Missing index 'IDX_EventTypes_IdElement' with hibernate.hbm2ddl.auto=update

* [JBPM-10224] Align ddl-scripts for mysql5 and mysqlinnodb with creation of index 'IDX_EventTypes_IdElement'

* [JBPM-10224] Align ddl-scripts for mysql5 and mysqlinnodb with creation of index 'IDX_EventTypes_Id'
github-actions bot pushed a commit that referenced this pull request Mar 26, 2024
…2395)

* [JBPM-10224] Missing index 'IDX_EventTypes_IdElement' with hibernate.hbm2ddl.auto=update

* [JBPM-10224] Align ddl-scripts for mysql5 and mysqlinnodb with creation of index 'IDX_EventTypes_IdElement'

* [JBPM-10224] Align ddl-scripts for mysql5 and mysqlinnodb with creation of index 'IDX_EventTypes_Id'
baldimir pushed a commit that referenced this pull request Jul 4, 2024
…2395) (#2409)

* [JBPM-10224] Missing index 'IDX_EventTypes_IdElement' with hibernate.hbm2ddl.auto=update

* [JBPM-10224] Align ddl-scripts for mysql5 and mysqlinnodb with creation of index 'IDX_EventTypes_IdElement'

* [JBPM-10224] Align ddl-scripts for mysql5 and mysqlinnodb with creation of index 'IDX_EventTypes_Id'

Co-authored-by: Daniele Mams <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-7.67.x Generate backport PR for 7.67.x branch backport-7.67.x-blue Generate backport PR for 7.67.x-blue branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants