Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KIEKER-1011] Compiling AbstractAspect with ajc lets eclipse complain #2826

Open
rju opened this issue Nov 12, 2024 · 5 comments
Open

[KIEKER-1011] Compiling AbstractAspect with ajc lets eclipse complain #2826

rju opened this issue Nov 12, 2024 · 5 comments

Comments

@rju
Copy link
Member

rju commented Nov 12, 2024

JIRA Issue: KIEKER-1011 Compiling AbstractAspect with ajc lets eclipse complain
Original Reporter: Christian Wulf


A little code example:

package monitoring.aspect;

import kieker.monitoring.probe.aspectj.flow.operationCall.AbstractAspect;

import org.aspectj.lang.annotation.Aspect;
import org.aspectj.lang.annotation.Pointcut;

Aspect
public class FileInputStreamProbe extends AbstractAspect {
Pointcut(...)
Override
public void monitoredOperation() {
// empty
}
}

When the AbstractAspect from Kieker is compiled with ajc, eclipse complains about not finding the method

monitoredOperation

to override in AbstractAspect. When compiling and exporting it with eclipse, the method is found.

@rju
Copy link
Member Author

rju commented Nov 12, 2024

author Unknown -- Tue, 10 Jul 2012 13:05:16 +0200

A first look reveals a difference in the definition of the abstract method in AbstractAspect. When compiling it with ajc, the bytecode modifier synthetic is additionally inserted.

A short description to synthetic.

@rju
Copy link
Member Author

rju commented Nov 12, 2024

author Jan Waller -- Tue, 10 Jul 2012 17:05:12 +0200

I can see the same problem here.
Eclipse is actually acting correctly, if a method is marked synthetic it should be ignored (handled as if not present).
The question is: Why does AspectJ mark this method synthetic?

@rju
Copy link
Member Author

rju commented Nov 12, 2024

author André van Hoorn -- Mon, 3 Sep 2012 15:22:19 +0200

Check if problem still present -> post AspectJ bug report

@rju
Copy link
Member Author

rju commented Nov 12, 2024

author Jan Waller -- Mon, 10 Sep 2012 11:28:30 +0200

Postet to aspectj
https://bugs.eclipse.org/bugs/show_bug.cgi?id=389146

@rju
Copy link
Member Author

rju commented Nov 12, 2024

author Jan Waller -- Mon, 10 Sep 2012 12:14:41 +0200

Currently, there is not much to do about this problem.
Hopefully it gets fixed in a future aspectj version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant