Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KIEKER-2001] Make ExplorViz Token Id and Secret Configurable #2841

Open
rju opened this issue Nov 12, 2024 · 0 comments
Open

[KIEKER-2001] Make ExplorViz Token Id and Secret Configurable #2841

rju opened this issue Nov 12, 2024 · 0 comments

Comments

@rju
Copy link
Member

rju commented Nov 12, 2024

JIRA Issue: KIEKER-2001 Make ExplorViz Token Id and Secret Configurable
Original Reporter: David Georg Reichelt


Currently, explorviz.token.id and explorviz.token.secret are hard-coded in the otel-transformer: https://github.com/kieker-monitoring/kieker/blob/main/tools/otel-transformer/src/kieker/tools/oteltransformer/stages/OpenTelemetryExporterStage.java#L196 This is only usable for demo purposes.

In addition to the export type, this should be somehow specified inside of the OpenTelemetry exporter stage. This is a somehow odd situation, because these two properties aren’t core OpenTelemetry properties. I see two ways to achieve this:

  • Easierst: Just have it as kieker.tools.oteltransformer.stages.OpentelemetryExporterStage.ExplorViz_TokenId and .ExplorViz_Secret, and document that these are special properties
  • Create a specialized ExplorVizExporterStage again, that inherits from the OpenTelemetryExporterStage and also sets these both properties

We should discuss at the Kieker meeting how to address this and then implement it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant