Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a regression test for the backing up and overwriting logic. #11

Open
kindaro opened this issue Feb 20, 2022 · 2 comments
Open

Add a regression test for the backing up and overwriting logic. #11

kindaro opened this issue Feb 20, 2022 · 2 comments

Comments

@kindaro
Copy link
Owner

kindaro commented Feb 20, 2022

As said in the overview of the package:

  1. Prettified files are backed up with the extension *.previous.

    1. Files that are already pretty are not backed up.

      This ensures that running cabal-prettify twice in a row does not overwrite the original.

This is hazardous. I should add a regression test.

@kindaro
Copy link
Owner Author

kindaro commented Apr 11, 2024

I figure this gets checked by the new examples test suite added in #17.

@kindaro kindaro closed this as completed Apr 11, 2024
@kindaro
Copy link
Owner Author

kindaro commented Apr 11, 2024

Actually it does not. It only checks that these files get created with the right content. We need to run cabal-prettify two times to check that the logic is working right.

@kindaro kindaro reopened this Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant