You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi,
The body of the function contains the following conditions:
if "element_numbering" in kwargs: (...)
Thus, only the existence of the key in kwargs triggers the annotation.
What if the condition is upgraded by an additional check if the value of element_numbering is True or False?
In such a way, the call to draw_mesh2d() and other functions would be more manageable, e.g. specifying: draw_mesh2d(, , element_numbering=True )
or draw_mesh2d(, , element_numbering=False )
The above applies to many other similar constructs. Such cosmetic change would limit the confusion of the programmer's instinct.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
Hi,
The body of the function contains the following conditions:
if "element_numbering" in kwargs: (...)
Thus, only the existence of the key in kwargs triggers the annotation.
What if the condition is upgraded by an additional check if the value of element_numbering is True or False?
In such a way, the call to draw_mesh2d() and other functions would be more manageable, e.g. specifying:
draw_mesh2d(, , element_numbering=True )
or
draw_mesh2d(, , element_numbering=False )
The above applies to many other similar constructs. Such cosmetic change would limit the confusion of the programmer's instinct.
Regards
MichaelT
Beta Was this translation helpful? Give feedback.
All reactions