Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider tracking Cargo.lock #555

Open
TomaSajt opened this issue Aug 5, 2024 · 0 comments
Open

Consider tracking Cargo.lock #555

TomaSajt opened this issue Aug 5, 2024 · 0 comments

Comments

@TomaSajt
Copy link
Contributor

TomaSajt commented Aug 5, 2024

Hello,
I maintain this package on Nixpkgs and our build process requires the presence of a Cargo.lock file to build a rust project (to achieve reproducible builds)

However, pyxel's repository does not provide the lockfile, since .gitignore blacklists the lockfile from being tracked

Currently we manually generate the lockfile and include it in our repository

Would you consider providing this file?

It is generally considered good practice that you provide a Cargo.lock file for the package if your rust program is built into a binary.

Here's what the Rust FAQ says: https://doc.rust-lang.org/cargo/faq.html#why-have-cargolock-in-version-control

Though, I see that this repository has a multi-project rust workspace where it might be a bit more annoying to work with lockfiles

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant