-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace allocator with mimalloc
#323
Comments
Has an issue about the unsoundness been raised in |
Yes, the issue is here: purpleprotocol/mimalloc_rust#96 Didn't seem to have gotten much attention from the maintainers though. If they fix it, I guess we can still switch. |
I'm just doing some little PRs on the And I'm looking into just upgrading it to v2.x since version 2 brings improvements in memory usage and fragmentation (according to the mimalloc README) |
I just read through the issue again, apparently it's just an issue with the Edit: Yeah, it's probably not the secure mode (see purpleprotocol/mimalloc_rust#98) |
We originally used mimalloc as the allocator for Kitsune and the search service via the
mimalloc
crate and then switched to jemalloc as kind of a band-aid fix for unsoundness inside themimalloc
crate (they return wrongly aligned pointers. Big no no.)There is the
mimalloc-rust
crate though which provides bindings that are actually sound.I personally prefer mimalloc over jemalloc since it's smaller, faster to build, and (according to their benchmarks) outperforms a lot of other allocators.
Right now we spend ~40-50sec of our total build time on building jemalloc. We can probably reduce that with mimalloc.
The text was updated successfully, but these errors were encountered: