-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Loading another router #3
Comments
To be honest i'm not really fond of how dashing deals with authentication via config.ru. Most dashing apps are deployed behind a reverse proxy like apache or nginx on which it's trivial to setup HTTP Basic Auth or IP range restrictions. On the other hand I'm not negative on allowing the user to specify additional routes. |
I have a couple use cases that I'm looking to accomplish. As you can see in cagedata/dashboard, we use Azure AD to authenticate to our dashboard app. The other is for webhook support as you mentioned in #4. For authentication, you could theoretically just take the opinionated route and pass to Ueberauth: if configured, force Ueberauth authentication, else the application is open. |
I'm thinking about implementing a forwarder in |
I'd love to see a prototype of this. |
I'm back to working on a prototype for this. With targeting Heroku as a deployment option, I think it's necessary to be able to support authentication since Heroku doesn't offer anything else. I'm playing with Ueberauth to manage the auth logic. |
Circling back and thinking about it, I think the way to build this feature out is to allow a config option to specify a custom router. Then in the |
It would be really nice to have a way to add more routes to dashboard, for example to add authentication to the dashboard. Similar to how Dashing had the config.ru which you could add routes to.
The text was updated successfully, but these errors were encountered: