Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge Bioanalyzer Service into BioAuthService #33

Open
ghost opened this issue Jul 28, 2021 · 0 comments
Open

Merge Bioanalyzer Service into BioAuthService #33

ghost opened this issue Jul 28, 2021 · 0 comments

Comments

@ghost
Copy link

ghost commented Jul 28, 2021

These two services have the same domain, are operating on the same concepts, have no dependencies outside each other, and even use the same technologies. Conceptually, they go together. Practically, they should go together. The task here is to merge them.

The new BioAuthService has a place for the bioanalyzer already (where it makes the cross-service call), which is where the old code from Bioanalyzer Service should go.

This will also involve a bunch of edits to existing tests, since there will no longer be a need for an HttpClient, so the scope is perhaps a little larger that it might seem at first glance.

@ghost ghost self-assigned this Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

0 participants