-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to latest nestjs everywhere #56
Comments
Here’s what I’m thinking may be the best approach: |
Keep in mind, going to the new version of nestjs breaks some things in downstream dependencies. I remember some problems with Reflector injection in the LoggingInterceptor. Decisions will need to be made to figure out if the change belongs in protocol-common or elsewhere. |
This makes a lot of sense. I should've made it a major version update to begin with. The change does unfortunately belong in protocol-common because like half of protocol-common uses these dependencies already. But yeah, maybe there are some things we can pull out and just implement on a per-service basis. |
We've updated a major version of nestjs in protocol-common, so we'll need to update nestjs downstream to ensure type compatibility
EDIT: public repos that need updating:
The text was updated successfully, but these errors were encountered: