Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outdated PureFTP docker image #315

Open
kelson42 opened this issue Mar 28, 2022 · 8 comments
Open

Outdated PureFTP docker image #315

kelson42 opened this issue Mar 28, 2022 · 8 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@kelson42
Copy link
Contributor

kelson42 commented Mar 28, 2022

Not updated since 6 years https://hub.docker.com/r/gimoh/pureftpd

Unfortuantely I don't have found any "official" Docker image to replace it.

@kelson42 kelson42 added the good first issue Good for newcomers label Mar 28, 2022
@kelson42
Copy link
Contributor Author

kelson42 commented Apr 2, 2022

Reusing https://github.com/InAnimaTe/docker-vsftpd-anon seems a good candidate

@kelson42
Copy link
Contributor Author

@rgaudin Had a look, and seems we will need anyway to keep our own Dockerfile. I don’t have found a good image ready to go.

@stale
Copy link

stale bot commented Aug 13, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

@kelson42 kelson42 pinned this issue Oct 1, 2023
@kelson42
Copy link
Contributor Author

kelson42 commented Oct 14, 2023

We could maybe replace with https://hub.docker.com/r/corpusops/pureftpd

@benoit74 @rgaudin Would that be straight to replace in k8s?

@benoit74
Copy link
Collaborator

Is there any reason why we would use an image with pureftpd build from source vs official apt package?

My natural suggestion would be to build our own pureftpd image based on debian + official pureftpd apt package, since we do not need cutting edge functionalities or specific options AFAIK, but I'm a newbie on our usage of pureftpd

The image you suggested is good, but still not updated for 6 months and based on a custom base image derived from Ubuntu with a custom pureftpd compilation. Not really something I feel confident to use.

But yes, using the new image is straightforward in k8s (either the one you found or a simple new one as suggested)

@kelson42
Copy link
Contributor Author

Is there any reason why we would use an image with pureftpd build from source vs official apt package?

Not really... beside lazyness I guesd ;)

My natural suggestion would be to build our own pureftpd image based on debian + official pureftpd apt package, since we do not need cutting edge functionalities or specific options AFAIK, but I'm a newbie on our usage of pureftpd

The image you suggested is good, but still not updated for 6 months and based on a custom base image derived from Ubuntu with a custom pureftpd compilation. Not really something I feel confident to use.

LGTM

But yes, using the new image is straightforward in k8s (either the one you found or a simple new one as suggested)

Considering the security concern the very old image image creates. Good to fix soon IMHO.

@rgaudin
Copy link
Member

rgaudin commented Oct 16, 2023

I've reviewed the changelog and I believe there would be no issue. I also support a custom debian:bookworm-slim image with the apt package.

FYI, pure-ftpd is used for anonymous FTP download from the server. It mounts the Kiwix downloads volume read-only.

@kelson42
Copy link
Contributor Author

@benoit74 @rgaudin If we all agree on this new image, could you please deploy it?

@kelson42 kelson42 transferred this issue from kiwix/container-images Nov 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants