Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"New tab" is in the middle #996

Open
kelson42 opened this issue Oct 4, 2024 · 5 comments
Open

"New tab" is in the middle #996

kelson42 opened this issue Oct 4, 2024 · 5 comments
Assignees
Milestone

Comments

@kelson42
Copy link
Contributor

kelson42 commented Oct 4, 2024

Image

... it should not be at the end of the list?

@BPerlakiH
Copy link
Collaborator

BPerlakiH commented Oct 5, 2024

I couldn't recreate this issue. If there are multiple tabs, the new one will open at the top.
You can have multiple "new tabs" if you open something in one of them, it won't re-sort the tabs to make the new tab(s) appear at the top. It will keep the chronological order of the tabs (sorted by opening time). Is that what you had in mind? I mean to always re-sort the tabs, so that new ones are always on the top?

@kelson42
Copy link
Contributor Author

kelson42 commented Oct 5, 2024

Actually I still don't understand how it works! I just discovered that the "new tab" just disappears when you open a content with it image

When/how it will reappear?

@BPerlakiH
Copy link
Collaborator

It works the same way as in Safari, you can open many new tabs, they will be empty, once you enter a url (in our case open a ZIM in it), it won't be empty anymore. Maybe this video explains it better:
https://github.com/user-attachments/assets/e4f2dea1-0ae7-4c20-aa87-250b8d0203a6

@BPerlakiH
Copy link
Collaborator

There's also long press on that [+] button, with which it's possible to close all tabs:

Image

@kelson42
Copy link
Contributor Author

I understand now, but there is a UX problem around rhis:

  • "+" too far from the tab list
  • Somehow duplicate purpose withe the "new tab" tab (why not just keeping always one of these open?)

Postponed to next milestone.

@kelson42 kelson42 modified the milestones: 3.6.0, 3.7.0 Oct 10, 2024
@kelson42 kelson42 self-assigned this Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants