Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

975 improve iphone launch sequence new #1000

Merged
merged 43 commits into from
Oct 10, 2024
Merged
Changes from 1 commit
Commits
Show all changes
43 commits
Select commit Hold shift + click to select a range
8b4b541
Add SplashScreen
BPerlakiH Sep 12, 2024
ee08110
Handle loading state for iPhone
BPerlakiH Sep 12, 2024
ef506a5
Fixlint
BPerlakiH Sep 12, 2024
586e8ce
Fix post loading state
BPerlakiH Sep 12, 2024
f4711f2
Centered logo loading
BPerlakiH Sep 14, 2024
1ba422f
Loading and LogoViews
BPerlakiH Sep 14, 2024
3577a0d
Clean up assets, align welcome screen
BPerlakiH Sep 14, 2024
bd1adcf
exclude splash from macOS
BPerlakiH Sep 15, 2024
99b2efb
Move Kiwix specific storyboard to separate folder
BPerlakiH Sep 17, 2024
8da2003
Revert the naming to common welcomeLogo
BPerlakiH Sep 17, 2024
d22b558
Replace image, fix image resize
BPerlakiH Sep 21, 2024
6ad3ca8
Add SplashScreen
BPerlakiH Sep 12, 2024
1fd7c2b
Handle loading state for iPhone
BPerlakiH Sep 12, 2024
93e35f4
Fixlint
BPerlakiH Sep 12, 2024
ec880a1
Centered logo loading
BPerlakiH Sep 14, 2024
4417548
Clean up assets, align welcome screen
BPerlakiH Sep 14, 2024
9027601
Move Kiwix specific storyboard to separate folder
BPerlakiH Sep 17, 2024
11059d5
Revert the naming to common welcomeLogo
BPerlakiH Sep 17, 2024
7d753b8
Replace image, fix image resize
BPerlakiH Sep 21, 2024
f2555fa
Revert safeArea for webview
BPerlakiH Sep 21, 2024
e1a350d
Update to NavigationSplitView for macOS
BPerlakiH Sep 29, 2024
06f6368
Change to one loader, and Fetching Catalog text
BPerlakiH Sep 29, 2024
77db59a
Revert
BPerlakiH Sep 29, 2024
813e07e
Fixup
BPerlakiH Sep 29, 2024
15fe200
Start with collapsed state for iPad/macOS
BPerlakiH Sep 29, 2024
b3ab2ce
Hide tab for iPad on loading, when there's no local ZIM files
BPerlakiH Sep 29, 2024
672779a
Clean up
BPerlakiH Sep 30, 2024
747eb1a
Use text as progress
BPerlakiH Oct 2, 2024
8ff9a08
Align logo
BPerlakiH Oct 6, 2024
cac1ec2
Use resizer
BPerlakiH Oct 6, 2024
c2cfb40
Add docs and refactor
BPerlakiH Oct 6, 2024
1c5815a
Fixlint
BPerlakiH Oct 6, 2024
8e0667e
Fixlint and update comments
BPerlakiH Oct 6, 2024
29d9007
Use 300 logo width for regular
BPerlakiH Oct 6, 2024
00768be
Add the same constraints to story board
BPerlakiH Oct 6, 2024
bd9d110
Remove empty file
BPerlakiH Oct 8, 2024
fdbcafb
Max logo width on macOS
BPerlakiH Oct 8, 2024
8f442b6
Revert LibraryViewModel
BPerlakiH Oct 8, 2024
bf9a039
Move the initial loading state into Welcome view
BPerlakiH Oct 9, 2024
8503871
Move hasSeenCategories to defaults, change library tab order
BPerlakiH Oct 9, 2024
9ca8979
Add safety path for upgrading user
BPerlakiH Oct 9, 2024
78f5f7d
Vertical center the logo and button block
BPerlakiH Oct 9, 2024
43f104e
Make space for error message when using compact height
BPerlakiH Oct 9, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixup
BPerlakiH committed Oct 6, 2024
commit 813e07ea78f8d9bdee953966aa2e411b7318ca65
7 changes: 6 additions & 1 deletion App/SplitViewController.swift
Original file line number Diff line number Diff line change
@@ -42,7 +42,12 @@ final class SplitViewController: UISplitViewController {
super.viewDidLoad()

// setup controllers
setViewController(UINavigationController(rootViewController: CompactViewController()), for: .compact)
setViewController(
UINavigationController(
rootViewController: CompactViewController(navigation: navigationViewModel)
),
for: .compact
)
setViewController(SidebarViewController(), for: .primary)
setSecondaryController()