Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev: refactor solidity contracts folder structure #1427

Open
obatirou opened this issue Sep 19, 2024 · 2 comments
Open

dev: refactor solidity contracts folder structure #1427

obatirou opened this issue Sep 19, 2024 · 2 comments
Assignees
@obatirou

Comments

@obatirou
Copy link
Collaborator

obatirou commented Sep 19, 2024 •
edited
Loading

  • Testing and production contracts are in the same directory. It should be separated.
  • Interfaces should have their own files.
  • Dependencies should be installed with forge and not copy/paste
  • imports should be standardized
  • add unit forge test for L2KakarotMessage
@github-project-automation github-project-automation bot moved this to 🆕 Backlog in Kakarot on Starknet Sep 19, 2024
@martinvibes
Copy link

hello @obatirou can i be assigned?

@onlydustapp OnlyDustApp
Copy link

onlydustapp bot commented Sep 24, 2024

Hey @martinvibes!
Thanks for showing interest.
We've created an application for you to contribute to Kakarot zkEVM.
Go check it out on OnlyDust!

matthieuauger pushed a commit to matthieuauger/kakarot that referenced this issue Nov 9, 2024
@tcoratger
bump reth to v1.0.8 (kkrt-labs#1427)
e90bed0 
* bump reth to v1.0.8

* fix

* fmt

* fix tests

* trunk fmt

* fix tests

* fix features

* fix clippy

* cargo update

* small fix

* some fix

* fix new reth rev after address serialization patch

* cargo update

* fix conflicts

* update submodule
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@obatirou obatirou

Labels
None yet
Projects
No open projects
Kakarot on Starknet
Status: 🔖 Current sprint
Milestone
No milestone
Development

No branches or pull requests
2 participants
@obatirou @martinvibes