From da6ba6331af58ffa1ee1e90bf5db133f98234e0b Mon Sep 17 00:00:00 2001 From: malatrax Date: Fri, 22 Nov 2024 15:42:11 +0100 Subject: [PATCH 1/3] fix: add rust downloads for the ci in trunk --- .trunk/trunk.yaml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/.trunk/trunk.yaml b/.trunk/trunk.yaml index 622bb1f..85e404f 100644 --- a/.trunk/trunk.yaml +++ b/.trunk/trunk.yaml @@ -23,6 +23,12 @@ runtimes: definitions: - type: rust system_version: allowed +downloads: + - name: rust + downloads: + - os: linux + url: https://static.rust-lang.org/dist/2024-01-04/rust-nightly-x86_64-unknown-linux-gnu.tar.gz + strip_components: 2 lint: definitions: - name: clippy From 510a30b145c3c5f9b0d5bf9b70e7f054aac66e1e Mon Sep 17 00:00:00 2001 From: malatrax Date: Fri, 22 Nov 2024 15:52:00 +0100 Subject: [PATCH 2/3] doc: add return for trace_evaluation of memory --- crates/brainfuck_prover/src/components/memory/table.rs | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/crates/brainfuck_prover/src/components/memory/table.rs b/crates/brainfuck_prover/src/components/memory/table.rs index ce914b3..d5ae4c5 100644 --- a/crates/brainfuck_prover/src/components/memory/table.rs +++ b/crates/brainfuck_prover/src/components/memory/table.rs @@ -190,6 +190,12 @@ impl MemoryTable { /// /// # Arguments /// * memory - The [`MemoryTable`] containing the sorted and padded trace as an array of rows. + /// + /// # Returns + /// A tuple containing the evaluated trace and claim for STARK proof. + /// + /// # Errors + /// Returns [`TraceError::EmptyTrace`] if the table is empty. pub fn trace_evaluation(&self) -> Result<(TraceEval, Claim), TraceError> { let n_rows = self.table.len() as u32; if n_rows == 0 { From 14b81440dce4e054daad0b001e0aa3faf6fb9be6 Mon Sep 17 00:00:00 2001 From: malatrax Date: Mon, 25 Nov 2024 09:26:14 +0100 Subject: [PATCH 3/3] fix: add rust cache --- .github/workflows/trunk-check.yaml | 6 ++++++ .trunk/trunk.yaml | 6 ------ 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/trunk-check.yaml b/.github/workflows/trunk-check.yaml index 6377762..bc25654 100644 --- a/.github/workflows/trunk-check.yaml +++ b/.github/workflows/trunk-check.yaml @@ -18,5 +18,11 @@ jobs: - name: Checkout uses: actions/checkout@v4 + - run: rustup update + - name: Rust cache + uses: Swatinem/rust-cache@v2 + with: + cache-on-failure: "true" + - name: Trunk Code Quality uses: trunk-io/trunk-action@v1 diff --git a/.trunk/trunk.yaml b/.trunk/trunk.yaml index 85e404f..622bb1f 100644 --- a/.trunk/trunk.yaml +++ b/.trunk/trunk.yaml @@ -23,12 +23,6 @@ runtimes: definitions: - type: rust system_version: allowed -downloads: - - name: rust - downloads: - - os: linux - url: https://static.rust-lang.org/dist/2024-01-04/rust-nightly-x86_64-unknown-linux-gnu.tar.gz - strip_components: 2 lint: definitions: - name: clippy