Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is it possible to install this plugin using knative-operator? #3695

Open
gilesrapkinb opened this issue Feb 12, 2024 · 8 comments
Open

Is it possible to install this plugin using knative-operator? #3695

gilesrapkinb opened this issue Feb 12, 2024 · 8 comments
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@gilesrapkinb
Copy link

I'm trying to install knative-eventing using the operator, with eventing-kafka-broker installed via additionalManifests in the KnativeEventing resource:

apiVersion: operator.knative.dev/v1beta1
kind: KnativeEventing
metadata:
  name: knative-eventing
  namespace: knative-eventing
spec:
  version: 1.13.1
  additionalManifests:
  - URL: https://github.com/knative-extensions/eventing-kafka-broker/releases/download/knative-v1.13.1/eventing-kafka-controller.yaml
  - URL: https://github.com/knative-extensions/eventing-kafka-broker/releases/download/knative-v1.13.1/eventing-kafka-broker.yaml

However, the operator is throwing an error on install:

Install failed with message: the version of the manifests ve6b002188068b4caebdba747eda522f465fa1583 of the component kafka-broker-config does not match the target version of the operator CR v1.13.1

It looks like the operator is blocking on applying the extra manifests because the resources in them have the label app.kubernetes.io/version: "e6b002188068b4caebdba747eda522f465fa1583" (It looks like the version label has the git SHA rather than the version tag?). Is this a bug? Or am I trying to use the wrong manifests to install with the operator?

@gilesrapkinb gilesrapkinb added the kind/bug Categorizes issue or PR as related to a bug. label Feb 12, 2024
@pierDipi
Copy link
Member

cc @houshengbo

@Cali0707
Copy link
Member

Cali0707 commented Apr 4, 2024

@pierDipi I think this might be a bug in how we are building our releases in this repo. Looking at the releases from eventing core resources, the app.kubernetes.io/version label is set to the semantic version (e.g. "1.12.6"), but for our ekb releases it is the git SHA.

Copy link
Contributor

github-actions bot commented Jul 4, 2024

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 4, 2024
@gilesrapkinb
Copy link
Author

/remove-lifecycle stale

@knative-prow knative-prow bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 5, 2024
Copy link
Contributor

github-actions bot commented Oct 4, 2024

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 4, 2024
@gilesrapkinb
Copy link
Author

/remove-lifecycle stale

@knative-prow knative-prow bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 4, 2024
@richardvflux
Copy link

The knative-eventing version is also not necessarily in sync with the kafka extension either, as i write the current versions for v14 are like 7 versions apart. So I can understand it comparing 1.14 but not 1.14.14 for example.

@richardvflux
Copy link

I pulled the manifests and uploaded them elsewhere and hand-edited them to fix the versioning and that confirms that the issue is definitely the sha vs version issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

No branches or pull requests

4 participants