-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update setting up Prometheus docs #5217
Comments
related issue: knative/eventing#6509 |
resolved by editing configmap apiVersion: v1
kind: ConfigMap
metadata:
name: config-observability
namespace: knative-serving
labels:
app.kubernetes.io/name: knative-serving
app.kubernetes.io/component: observability
app.kubernetes.io/version: "1.7.1"
annotations:
knative.dev/example-checksum: "fed4756e"
data:
metrics.backend-destination: prometheus
metrics.request-metrics-backend-destination: prometheus |
I think we need to add below block to setting up prometheus part. https://knative.dev/docs/serving/observability/metrics/collecting-metrics/#setting-up-prometheus
|
@DevSusu: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/good-first-issue |
@evankanderson: Please ensure the request meets the requirements listed here. If this request no longer meets these requirements, the label can be removed In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @afzal442 |
Can I help? |
/assign |
The config map is to be set before we apply the ServiceMonitors/PodMonitors to collect metrics from Knative, right? |
/assign |
Editing the config map with specified commands. Issue knative#5217.
Please assign me this issue |
psschwei: originally opened in serving and moved here. updates needed for docs can be found in this comment: #5217 (comment)
/area monitoring
What version of Knative?
1.7.1
(installed with https://github.com/knative/serving/releases/download/knative-v1.7.1/serving-core.yaml)Expected Behavior
Actual Behavior
I had to specify the
metrics.backend-destination
andmetrics.request-metrics-backend-destination
to get this working.Steps to Reproduce the Problem
The text was updated successfully, but these errors were encountered: