You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When calling columnInfo with a table and column name, if the search query returns undefined the function throws Cannot read property 'COLUMN_NAME' of undefined when mapping the response to Column.
This can be easily fixed, but it feels like we should consider what return type we want in this scenario. Personally I think columnInfo should return Column | undefined in this instance, but this would be a breaking change.
The text was updated successfully, but these errors were encountered:
I personally feel like this function should return undefined, which lines up more with how other knex functions operate. But I also don't think it's worth doing a major increment just to make things a bit nicer! So probably best to just throw an error for now.
When calling
columnInfo
with a table and column name, if the search query returns undefined the function throwsCannot read property 'COLUMN_NAME' of undefined
when mapping the response toColumn
.This can be easily fixed, but it feels like we should consider what return type we want in this scenario. Personally I think
columnInfo
should returnColumn | undefined
in this instance, but this would be a breaking change.The text was updated successfully, but these errors were encountered: