Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serverless Plugin Optimize issue #3701

Closed
suryacaprice opened this issue Mar 4, 2020 · 1 comment
Closed

Serverless Plugin Optimize issue #3701

suryacaprice opened this issue Mar 4, 2020 · 1 comment

Comments

@suryacaprice
Copy link

Enigmatic-Smile/serverless-plugin-optimize#79

as mentioned in the issue we have to tweak the plugin to make knex work with Serverless Plugin Optimize can anyone raise a PR to make it as a part of the knex stable build ?

@elhigu
Copy link
Member

elhigu commented Mar 4, 2020

I didn't see anything in that issue that should go to knex repo... it wasn't even PR nor there was any code. Please open PR with changes to knex if you need some internal changes to be applied. If they are reasonable they can be merged to the project.

Closing as this doesn't follow issue template and its not clear what needs to be done and there is no idea with which knex version in what environment issue manifests.

@elhigu elhigu closed this as completed Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants