Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"startReturnTimer" not called in "widget_pagebutton.js" #169

Open
juniormajor opened this issue Oct 23, 2016 · 4 comments
Open

"startReturnTimer" not called in "widget_pagebutton.js" #169

juniormajor opened this issue Oct 23, 2016 · 4 comments

Comments

@juniormajor
Copy link

since last update the return function within the pagebutton isn't triggered anymore.
last known working version 23b63a9 (pre "Improved pointer events handler")

@knowthelist
Copy link
Owner

can't trace this. no issue found

@juniormajor
Copy link
Author

To clarifiy the issue:
until the rework of the pointer events, pagebutton has the same capability
as pagetab regarding the return to a specified page after x seconds ()
defined as attr return-time.
Since the rework the return timer isn't started at all. So automatic return
to a specific page isn't possible anymore.

Or do you mean you need logs?

Am 24.10.2016 2:12 vorm. schrieb "knowthelist" [email protected]:

can't trace this. no issue found


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#169 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABn4h_iXHL4CSyPW2GCA_IqGE93ZL6v6ks5q2_fpgaJpZM4KeLKl
.

@knowthelist
Copy link
Owner

The condition to trigger the return timer is:
data-return-time of the first pagebutton >0 and at least tap/click of the screen after an activation of a new pagebutton.

       // start return timer after last activity
       if ( me.elements.eq(0).data('return-time') > 0 ){
           $('body').once('touchend mouseup', function(e) {
               startReturnTimer(me.elements.eq(0));
               e.preventDefault();
           });
       }

If you just change the view via pagebutton and don't click on the screen, the timer wont start. Maybe this is the problem, isn't it? Should be changed to: return in any case.

@juniormajor
Copy link
Author

juniormajor commented Oct 26, 2016

indeed, absolutely correct! nevertheless old behaviour was that the timer was triggered without "additional click". just change the view via click onto the pagebutton and timer was triggered.

would it be hard to reimplement the old behaviour?

2016-10-26 6:32 GMT+02:00 knowthelist [email protected]:

The condition to trigger the return timer is:
data-return-time of the first pagebutton >0 and at least tap/click of the
screen after an activation of a new pagebutton.

   // start return timer after last activity
   if ( me.elements.eq(0).data('return-time') > 0 ){
       $('body').once('touchend mouseup', function(e) {
           startReturnTimer(me.elements.eq(0));
           e.preventDefault();
       });
   }

If you just change the view via pagebutton and don't click on the screen,
the timer wont start. Maybe this is the problem, isn't it? Should be
changed to: return in any case.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#169 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABn4h-lhsjmqnv8hf7siXhJJZFqBDLzCks5q3tfqgaJpZM4KeLKl
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants