Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Classchanger widget no longer recognizes data-get-on/off #207

Open
AndLindemann opened this issue Sep 9, 2017 · 1 comment
Open

Classchanger widget no longer recognizes data-get-on/off #207

AndLindemann opened this issue Sep 9, 2017 · 1 comment

Comments

@AndLindemann
Copy link

Since commit b466d6f the classchanger widget no longer recognizes data-get-on and data-get-off parameters. It just compares against data-get against "on" or "off".
Is this intended?

@AndLindemann
Copy link
Author

AndLindemann commented Sep 9, 2017

In fact, since the update from yesterday, classchanger seems to be broken completely. It fails to add the on-class on initial page load, possibly due to reasons caused in some other reworked javascripts.
I had to revert the complete update from yesterday to get it back to working state, as reverting widget_classchanger.js was not enough, it still failed to update correctly. Only after a complete restore it worked again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant