Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Config item in scribe.php for CSS #51

Closed
pirex360 opened this issue Jun 30, 2020 · 5 comments
Closed

[Feature request] Config item in scribe.php for CSS #51

pirex360 opened this issue Jun 30, 2020 · 5 comments

Comments

@pirex360
Copy link

pirex360 commented Jun 30, 2020

Hi,

If it's possible i suggest to create a variable into scribe.php for internal css for documentation.
It can be :

$internalcss = <<< CSS
<style>
.params{
  font-weight:bold;
}
</style>
CSS;

This feature will create some freedom in css formating, that is missing.

Best Regards, keep up the good work.

@pirex360 pirex360 added the question Further information is requested label Jun 30, 2020
@pirex360 pirex360 changed the title New feature in scribe.php New feature in scribe.php for CSS Jun 30, 2020
@pirex360 pirex360 changed the title New feature in scribe.php for CSS New feature request in scribe.php for CSS Jun 30, 2020
@shalvah
Copy link
Contributor

shalvah commented Jul 3, 2020

Hmmm. I'm reluctant to add any styling changes like this to the config, until Pastel supports such at least.

How about injecting it into the generated Markdown instead? You can put a <style> tag anywhere (or even create a prepend.md containing that only, and it should be properly moved into the head by the browser.

@shalvah shalvah changed the title New feature request in scribe.php for CSS [Feature request] Config item in scribe.php for CSS Jul 3, 2020
@shalvah shalvah added feature-request and removed question Further information is requested labels Jul 3, 2020
@shalvah
Copy link
Contributor

shalvah commented Jul 17, 2020

Hmmm. I'm reluctant to add any styling changes like this to the config, until Pastel supports such at least.

How about injecting it into the generated Markdown instead? You can put a <style> tag anywhere (or even create a prepend.md containing that only, and it should be properly moved into the head by the browser.

I think this should work, but if you want a more elegant solution, we're having a related discussion in Pastel. If we can get support for custom styles in there, we can easily expose that as an option here.

@shalvah
Copy link
Contributor

shalvah commented Sep 25, 2020

See the RFC that would help with this: #105

With this, you could add custom CSS, probably in your Laravel config file.

@shalvah
Copy link
Contributor

shalvah commented Jun 5, 2021

Scribe v3 (likely released next week) comes with a new theming system that eliminates the need for Pastel, so I'm closing this. You can create your own theme, and (though it's a bit of work), modify the default.

@shalvah
Copy link
Contributor

shalvah commented Jun 7, 2021

🎉v3 is out now, with the new theming system.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants