Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buy from the creator on collection #5453

Closed
JustLuuuu opened this issue Mar 31, 2023 · 13 comments
Closed

Buy from the creator on collection #5453

JustLuuuu opened this issue Mar 31, 2023 · 13 comments
Labels
$ ~<50usd A-collection work being done collection view A-rmrk2 enhancement New feature or request p3 non-core, affecting less than 40%

Comments

@JustLuuuu
Copy link
Member

JustLuuuu commented Mar 31, 2023

Is your feature request related to a problem?

Can we have the option to filter NFTs only for those that are sold by the creator? 🥹
image

Our menu on the left will look less "empty". 👯

Describe the solution you would like

Add filter sold be creator or buy from creator or something similar

Describe alternatives you have considered

Screenshots

No response

Are there opened related issues?

No response

@JustLuuuu JustLuuuu added the enhancement New feature or request label Mar 31, 2023
@JustLuuuu JustLuuuu changed the title Buy from the owner Buy from the creator Mar 31, 2023
@yangwao
Copy link
Member

yangwao commented Mar 31, 2023

What does it do?
It will show only NFTs which being sold by creator and not second owner right?
That's possible!
i.e. showing NFTs which are LISTed with same owner as minter.

Good q, should we show even for example creator buy back them and listed them again?
I guess that's same case sort of.

cc @vikiival

@yangwao yangwao added p3 non-core, affecting less than 40% A-explorer A-rmrk2 $ ~<50usd labels Mar 31, 2023
@JustLuuuu
Copy link
Member Author

Good q, should we show even for example creator buy back them and listed them again? I guess that's same case sort of.

yeah I think thanks kind of the same. So if the address of the seller is the same as the creator then it will be filtered.

@vikiival
Copy link
Member

I understand it as:
Filter NFTs from collection where issuer == currentOwner

@vikiival
Copy link
Member

@JustLuuuu is this on explorer or on collection detail?

@JustLuuuu
Copy link
Member Author

@JustLuuuu is this on explorer or on collection detail?

they have it on both. Explorer if you have NFTs not colections

@yangwao yangwao added the A-collection work being done collection view label Mar 31, 2023
@yangwao
Copy link
Member

yangwao commented Mar 31, 2023

on explorer or on collection detail?

we can have it on both.

@vikiival
Copy link
Member

vikiival commented Apr 2, 2023

on explorer or on collection detail?

we can have it on both.

On collection is super easy to do

On explorer I need to write resolver or do other magic

@yangwao
Copy link
Member

yangwao commented Apr 17, 2023

On collection is super easy to do

we can do this one here

@yangwao yangwao changed the title Buy from the creator Buy from the creator on collection Apr 17, 2023
@iMac7
Copy link
Contributor

iMac7 commented Mar 10, 2024

👋

@kodabot
Copy link
Collaborator

kodabot commented Mar 10, 2024

ASSIGNED - @iMac7 🔒 LOCKED -> Monday, March 11th 2024, 07:25:29 UTC -> 24 hours

@kodabot
Copy link
Collaborator

kodabot commented Mar 11, 2024

ASSIGNMENT EXPIRED - @iMac7 has been unassigned.

@iMac7
Copy link
Contributor

iMac7 commented Mar 11, 2024

cmon @kodabot take a weekend off 🤣

@iMac7 iMac7 mentioned this issue Mar 12, 2024
16 tasks
@vikiival vikiival closed this as not planned Won't fix, can't repro, duplicate, stale Jul 31, 2024
@vikiival
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
$ ~<50usd A-collection work being done collection view A-rmrk2 enhancement New feature or request p3 non-core, affecting less than 40%
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants