Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Same item twice in explore feed #6677

Closed
exezbcz opened this issue Aug 11, 2023 · 19 comments · Fixed by #6855
Closed

Same item twice in explore feed #6677

exezbcz opened this issue Aug 11, 2023 · 19 comments · Fixed by #6855
Assignees
@leo-1228
Labels
$ ~<50usd A-explorer bug Something isn't working p2 core functionality, or is affecting 60% of app

Comments

@exezbcz
Copy link
Member

exezbcz commented Aug 11, 2023

image

  • added two items to cart - number of items 2
    image

  • scrolled bit more to see the same selected items

  • why is this happening? Looks like more same items are there.
@exezbcz exezbcz added bug Something isn't working p3 non-core, affecting less than 40% A-explorer labels Aug 11, 2023
@stephenjason89
Copy link
Contributor

Hello @exezbcz can i have this issue?

@exezbcz
Copy link
Member Author

exezbcz commented Aug 12, 2023

@stephenjason89 yes sir, no one raised pr nor got assigned

@stephenjason89
Copy link
Contributor

Thanks @exezbcz

@stephenjason89
Copy link
Contributor

👋

@kodabot
Copy link
Collaborator

kodabot commented Aug 14, 2023

ASSIGNED - @stephenjason89 🔒 LOCKED -> Tuesday, August 15th 2023, 06:10:36 UTC -> 24 hours

@kodabot
Copy link
Collaborator

kodabot commented Aug 15, 2023

ASSIGNMENT EXPIRED - @stephenjason89 has been unassigned.

@stephenjason89
Copy link
Contributor

stephenjason89 commented Aug 15, 2023 •
edited
Loading

Oh no i thought this was 6:10pm my timezone
Forgot it is UTC
Can't i work on this anymore?
Haven't started on it yet

@exezbcz
Copy link
Member Author

exezbcz commented Aug 15, 2023

@stephenjason89 I think you can. Ideally, it would be best if you raised pr before anyone else gets assigned

@stephenjason89
Copy link
Contributor

Thank you @exezbcz will do so later.

@stephenjason89
Copy link
Contributor

@exezbcz found the problem gonna make PR now

@stephenjason89 stephenjason89 mentioned this issue Aug 16, 2023
Closed
16 tasks
@stephenjason89
Copy link
Contributor

👋

@kodabot
Copy link
Collaborator

kodabot commented Aug 16, 2023

ALREADY UNASSIGNED - @stephenjason89, you cannot be assigned twice!

@stephenjason89 stephenjason89 mentioned this issue Aug 21, 2023
Merged
16 tasks
@Jarsen136 Jarsen136 mentioned this issue Aug 21, 2023
Closed
5 tasks
@prury prury added S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked and removed S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked labels Aug 23, 2023
@exezbcz
Copy link
Member Author

exezbcz commented Sep 3, 2023

still happens

Screen.Recording.2023-09-03.at.18.13.08.mov

https://canary.kodadot.xyz/ksm/explore/items?listed=true

maybe something wrong with this collection? https://canary.kodadot.xyz/ksm/explore/items?listed=true

@exezbcz exezbcz reopened this Sep 3, 2023
@exezbcz exezbcz added p2 core functionality, or is affecting 60% of app and removed p3 non-core, affecting less than 40% labels Sep 3, 2023
@newraina
Copy link
Member

newraina commented Sep 4, 2023 •
edited
Loading

The issue is in the query result. I noticed that the default ordering is blockNumber_DESC, and for those nfts under the same blockNumber, the order of return is randomized each time, so it is possible for the same nft to appear in the first page of the query and the second page of the query at the same time.

Maybe we could change the default sort to blockNumber_DESC + Alphabetically? Or by created time? This way we can get a more stable sorting result.

Here are the results of the first and second pages of the query when the problem is reproduced

1st page:

CleanShot 2023-09-04-bgFTd8d8@2x

2nd page:

CleanShot 2023-09-04-yG2vGt8e@2x

@yangwao yangwao added the $ ~<50usd label Sep 25, 2023
@leo-1228
Copy link

leo-1228 commented May 13, 2024 •
edited
Loading

👋

@vikiival
Copy link
Member

Wasn't this fixed by TokenEntity
cc @daiagi

@leo-1228
Copy link

I sent pull request , check it out.

@daiagi
Copy link
Contributor

daiagi commented May 15, 2024

  1. not sure why it's open. was supposedly fixed by fix: duplicate items in itemsGrid #6855
  2. TokenEntity was never implemented on ksm/rmrk2.

@vikiival vikiival mentioned this issue May 15, 2024
Open
@vikiival
Copy link
Member

@vikiival vikiival closed this as not planned Won't fix, can't repro, duplicate, stale May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leo-1228 leo-1228

Labels
$ ~<50usd A-explorer bug Something isn't working p2 core functionality, or is affecting 60% of app
Projects
None yet
Milestone
No milestone
9 participants
@stephenjason89 @yangwao @newraina @vikiival @daiagi @prury @exezbcz @kodabot @leo-1228