Kohana_Core::error_handler bypasses HTTP_Exception_500 handlers

[baronmog]

In Kohana/Core.php:990, the error_handler() function throws ErrorException (not HTTP_Exception), which leads to Kohana_Exception::_handler() manually creating a response with a status of 500, bypassing both the HTTP_Exception_500 and generic HTTP_Exception handlers.

public static function error_handler($code, $error, $file = NULL, $line = NULL)
{
    if (error_reporting() & $code)
    {
        // This error is not suppressed by current error reporting settings
        // Convert the error into an ErrorException
        throw new ErrorException($error, $code, 0, $file, $line);
    }

    // Do not execute the PHP error handler
    return TRUE;
}

[enov]

I think it is OK to throw an ErrorException at that line.

Probably Kohana_Exception should be converted to an HTTP_Exception here:
https://github.com/kohana/core/blob/3.4/develop/classes/Kohana/Request/Client/Internal.php#L125

Should we revisit Kohana_Exception? Being the top most Exception in Kohana, it should not know about its child HTTP_Exception, and should not generate a Response with a View. Also it has 2 handler functions, one with underscore.

[neo22s]

Review with new exception for PHP7