Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support exactly one cell output #34

Open
kokes opened this issue Feb 10, 2019 · 1 comment
Open

Support exactly one cell output #34

kokes opened this issue Feb 10, 2019 · 1 comment

Comments

@kokes
Copy link
Owner

kokes commented Feb 10, 2019

As discovered in #28, we sometimes render multiple cell outputs, but we should always render just one. There is an ordering defined in nbconvert, so we should check each when parsing the data field.

Before implementing this

  1. let's check a few notebooks (from tests, see Build regression tests and a harness #33) and how they render before and after.
  2. see if we can implement some of the mime types that are not yet supported (e.g. application/pdf?)
  3. grep as many notebooks as possible and check their mime types - maybe there our some extra mime types out there
@kokes
Copy link
Owner Author

kokes commented Feb 10, 2019

We're now rendering at most one cell output (255fc3e) and I've checked it all against the tests in nbformat and nbconvert, but I have yet to resolve the other points in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant