Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-monospace font is being used in monospace fonts #527

Open
1 task done
ltlapy opened this issue Nov 6, 2024 · 0 comments
Open
1 task done

Non-monospace font is being used in monospace fonts #527

ltlapy opened this issue Nov 6, 2024 · 0 comments

Comments

@ltlapy
Copy link
Contributor

ltlapy commented Nov 6, 2024

๐Ÿ’ก Summary

๊ณ ์ •ํญ์ด ์•„๋‹Œ ๊ธ€๊ผด์ด ๊ณ ์ •ํญ ํฐํŠธ๋กœ ์ง€์ •๋˜์–ด ์žˆ์Œ

https://github.com/kokonect-link/cherrypick/blob/4.13.0-beta.1/packages/frontend/src/style.scss#L15-L16 ์—์„œ ์ง€์ •๋˜์–ด ์žˆ๋Š” ๋ฐ”์™€ ๊ฐ™์ด, ๊ณ ์ •ํญ ๊ธ€๊ผด์ด ์•„๋‹Œ Pretendard JP ๊ฐ€ ์‚ฌ์šฉ๋˜์–ด ๊ณ ์ •ํญ ๊ธ€๊ผด ์‚ฌ์šฉ์ด ํ•„์š”ํ•œ ๊ณณ์˜ ์ž๊ฐ„์ด ์ด์ƒํ•ด์ง€๋Š” ๋ฌธ์ œ๊ฐ€ ๋ฐœ์ƒ

maybe related with #520

๐Ÿฅฐ Expected Behavior

monospace๊ฐ€ ์‚ฌ์šฉ๋˜๋Š” MFM code block, Scratchpad ๋“ฑ์—์„œ CJK ๋ฌธ์ž์™€ ๊ฐ™์ด Pretendard JP์œผ๋กœ fallback๋˜๋Š” ๋ฌธ์ž๋ฅผ ์‚ฌ์šฉํ–ˆ์„ ๋•Œ, ๋ชจ๋“  ๋ฌธ์ž๊ฐ€ ์ผ์ •ํ•œ ๊ฐ„๊ฒฉ์— ๋งž์ถ”์–ด ํ‘œ์‹œ๋จ

๐Ÿคฌ Actual Behavior

Pretendard JP์œผ๋กœ fallback๋˜๋Š” ๋ฌธ์ž๊ฐ€ ํ˜ผํ•ฉ๋œ ์ค„์—์„œ, ๋ฌธ์ž๊ฐ€ ๊ณ ์ •ํญ์„ ๋ฒ—์–ด๋‚˜๋Š” ๋ฌธ์ œ๊ฐ€ ๋ฐœ์ƒ

4.12.1 ๋ฐ 4.13.0-beta.1 ๊ธฐ์ค€์œผ๋กœ, #520 ์—์„œ ๋ชจ๋“  monospace ๊ธ€๊ผด์„ ์น˜ํ™˜ํ•˜์ง€ ์•Š์Œ์— ๋”ฐ๋ผ, ํ•ด๋‹น PR์—์„œ ์–ธ๊ธ‰ํ•œ ๋ฌธ์ œ๊ฐ€ ํ•ด๊ฒฐ๋˜์ง€ ์•Š์•„ ๋ณด์ด๋Š” ํ˜„์ƒ์ด ๋ณตํ•ฉ์ ์œผ๋กœ ๋‚˜ํƒ€๋‚  ์ˆ˜ ์žˆ์Šต๋‹ˆ๋‹ค.

๐Ÿ“ Steps to Reproduce

monospace๊ฐ€ ์‚ฌ์šฉ๋˜๋Š” MFM code block, Scratchpad ๋“ฑ์—์„œ CJK ๋ฌธ์ž์™€ ๊ฐ™์ด Pretendard JP์œผ๋กœ fallback๋˜๋Š” ๋ฌธ์ž๋ฅผ ์‚ฌ์šฉ

๐Ÿ’ป Frontend Environment

* CherryPick: 4.13.0-beta.1

๐Ÿ›ฐ Backend Environment (for server admin)

* Installation Method or Hosting Service:
* CherryPick:
* Node:
* PostgreSQL:
* Redis:
* OS and Architecture:

Do you want to address this bug yourself?

  • Yes, I will patch the bug myself and send a pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant