This repository has been archived by the owner on Dec 15, 2020. It is now read-only.
add host additional info filters #2330
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zwass
reviewed
Oct 14, 2020
There was a problem hiding this comment.
My biggest concern with this implementation is that every request would extract all of the additional information from MySQL before performing the filtering. Do you think we could make use of the JSON_EXTRACT function to avoid that? Would it allow filtering in the ways that you need?
|
TIL about JSON_EXTRACT... yes that seems like a viable option. I'll work on changes to use that instead. |
Co-authored-by: Mike McNeil <[email protected]>
Fixes an issue in which the status was erroneously displayed after results were printed.
Use --pretty to enable this feature. This will likely break on non-ANSI terminals.
Changes in #2327 broke the MySQL syntax for listing hosts with online status. This was not caught due to the lack of a unit test for the functionality. This PR adds a unit test and fixes the regression.
Updated the 500 page component to render a "SHOW ERROR" button. This button is only rendered if the errors slice of the state contains an error and the base property exists. Otherwise, the 500 page will not render this button because there is no error message to show the user. Created a errors500 reducer and actions to update the state tree when a 500 error occurs. When 500 error occurs, the errors slice of state is updated with the error object. When the 500 page component unmounts the error object is removed from state. Demo: https://www.loom.com/share/b87c4aee42274e7bb553e703d3f950c6
- Modify column collation to make comparisons case-sensitive. - Add tests for case-sensitivity. Fixes #2333
- Allow user creation via `fleetctl user create` - Cleanup and rename existing methods for clarity Fixes #2306
- Allow download of enroll secret, server certificate, and flagfile. - Hosts can now be added following instructions directly.
Created 3 new components: <OsqueryOptionsPage /> , <OsqueryOptionsForm />, and <YamlAce /> The <OsqueryOptionsPage /> component is rendered at the new route /admin/osquery. The user navigates to this route by selecting the "Osquery Options" sub-navigation in the admin dropdown menu. On the Osquery Options page, the user is presented with a ACE editor filled with the current osquery options. The current osquery options are retrieved from the serve when the page component mounts. These current osquery options are stored in the osquery slice of state. Clicking "UPDATE OPTIONS" will trigger a form submit and hit the v1/kolide/spec/osquery_options endpoint if the yaml is valid. If the yaml is not valid, an error message is presented to the user with details on what the error is and where it occurred. If the yaml is valid, the osquery options will be updated even if the options haven't change.
- Add endpoints for osquery to register and continue a carve. - Implement client functionality for retrieving carve details and contents in fleetctl. - Add documentation on using file carving with Fleet. Addresses #1714
This is just favicons and pngs - more to do here later. But this does the easy ones.
This is another error introduced in #2327 we did not catch previously due to insufficient unit test coverage. Test is now added.
One additional spot that was missed previously.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My initial take on implementing #2329. Adds a new
additional_info_filtersquery param to the/api/v1/kolide/hostsendpoint that takes a comma delimited list of additional fields to include in the result.