-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SDCICD-1338: custom task to generate OLM catalog #1170
Conversation
425ed90
to
e2c8fdb
Compare
/ok-to-test |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't have much experience with operators, but the task does look reasonable.
I'm just wondering - the combo of this task and #1153 generates a lot of additional source files. Should we try to include them in source containers (https://github.com/konflux-ci/build-definitions/tree/main/task/source-build/0.1)?
On the other hand, a source repo + a pipeline that uses those two tasks should generate the same files every time (hopefully?) so I'd say we can treat that as intermediate build-system artifacts and don't need to distribute the sources
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm. I thought I had reviewed this a while ago, but everything is pending. Apologies!
105ee52
to
0072218
Compare
Add a new custom task to generate the OLM catalog based on a bundle image. This creates the Dockerfile and generates the catalog contents by adding a single bundle and a single channel entry for that bundle to the catalog with a skip range to the latest version. OLM can then be treated in such a way that it will always upgrade to the latest version available in the catalog. following the documentation[1] for creating raw FBCs [1]: https://olm.operatorframework.io/docs/tasks/creating-a-catalog/#catalog-creation-with-raw-file-based-catalogs PR konflux-ci#1153 will be used to generate the bundle that is fed into this task as a parameter. SRE-P operators are maintained without actively versioning or managing upgrade graphs; the latest version is always the version that should be running. Signed-off-by: Brady Pratt <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, not sure if you still want to resolve https://github.com/konflux-ci/build-definitions/pull/1170/files#r1689022235
@chmeliik resolved! This should be ready to go 🚀 |
Add a new custom task to generate the OLM catalog based on a bundle image. This creates the Dockerfile and generates the catalog contents by adding a single bundle and a single channel entry for that bundle to the catalog with a skip range to the latest version. OLM can then be treated in such a way that it will always upgrade to the latest version available in the catalog.
following the documentation1 for creating raw FBCs
PR #1153 will be used to generate the bundle that is fed into this task as a parameter. SRE-P operators are maintained without actively versioning or managing upgrade graphs; the latest version is always the version that should be running.
task output