Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rpm-ostree: drop BASE_IMAGES_DIGESTS result #1178

Merged
merged 2 commits into from
Jul 30, 2024
Merged

rpm-ostree: drop BASE_IMAGES_DIGESTS result #1178

merged 2 commits into from
Jul 30, 2024

Conversation

chmeliik
Copy link
Contributor

@chmeliik chmeliik commented Jul 22, 2024 •
edited by openshift-ci bot
Loading

STONEBLD-2326

For consistency with the buildah tasks, don't return BASE_IMAGES_DIGESTS from rpm-ostree either.

@chmeliik chmeliik force-pushed the rpm-ostree-drop-base-images-digests branch 2 times, most recently from 021ac0c to 5fb02a6 Compare July 22, 2024 12:55
@chmeliik
Copy link
Contributor Author

Note to self: will need to rebase once #1111 makes it through the merge queue

@chmeliik chmeliik force-pushed the rpm-ostree-drop-base-images-digests branch from 5fb02a6 to 8af2089 Compare July 24, 2024 07:50
@chmeliik chmeliik added this pull request to the merge queue Jul 24, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 24, 2024
@zregvart zregvart added this pull request to the merge queue Jul 24, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 24, 2024
@chmeliik chmeliik marked this pull request as draft July 25, 2024 07:38
@chmeliik
Copy link
Contributor Author

chmeliik commented Jul 25, 2024 •
edited
Loading

There's currently an internal Slack thread ongoing about EC blocking releases of images that don't have a BASE_IMAGES_DIGESTS result and have no base images in the SBOM (which would be the expected state for this task in 0.2). I'll mark this as draft until that's resolved

@chmeliik chmeliik force-pushed the rpm-ostree-drop-base-images-digests branch from 8af2089 to 44d5475 Compare July 25, 2024 12:23
@chmeliik chmeliik marked this pull request as ready for review July 25, 2024 12:23
@chmeliik
Copy link
Contributor Author

There's currently an internal Slack thread ongoing about EC blocking releases of images that don't have a BASE_IMAGES_DIGESTS result and have no base images in the SBOM (which would be the expected state for this task in 0.2). I'll mark this as draft until that's resolved

This was a different issue (missing vendor="Red Hat, inc." label, due to which EC didn't read the SBOM embedded in the image).

Rebased on main, un-drafted

chmeliik added 2 commits July 30, 2024 10:07
@chmeliik
Copy rpm-ostree/0.1 -> rpm-ostree/0.2
f82a083 
This is preparation for creating version 0.2 of rpm-ostree. Start by
creating a 1:1 copy to make reviews and rebasing easier.

Signed-off-by: Adam Cmiel <[email protected]>
@chmeliik
rpm-ostree 0.2: drop BASE_IMAGES_DIGESTS
5581493 
STONEBLD-2326

The result never provided any value. Drop it.

Signed-off-by: Adam Cmiel <[email protected]>
@chmeliik chmeliik force-pushed the rpm-ostree-drop-base-images-digests branch from 44d5475 to 5581493 Compare July 30, 2024 08:07
@zregvart zregvart added this pull request to the merge queue Jul 30, 2024
Merged via the queue into konflux-ci:main with commit db5c10d Jul 30, 2024
9 checks passed
@rh-tap-build-team rh-tap-build-team bot mentioned this pull request Jul 30, 2024
Closed
@chmeliik chmeliik deleted the rpm-ostree-drop-base-images-digests branch July 30, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zregvart zregvart zregvart approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chmeliik @zregvart