Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(STONEINTG-946): migrate redhat-appstudio/konflux-test #1649

Merged
merged 2 commits into from
Dec 11, 2024
Merged

feat(STONEINTG-946): migrate redhat-appstudio/konflux-test #1649

merged 2 commits into from
Dec 11, 2024

Conversation

Josh-Everett
Copy link
Contributor

@Josh-Everett Josh-Everett commented Nov 25, 2024 •
edited
Loading

Update references to redhat-appstudio quay repo to reflect move to konflux-ci org. Existing images have been copied to new repo to maintain functionality.

@Josh-Everett Josh-Everett force-pushed the integration_quay_reorg branch 2 times, most recently from 4040205 to d5e2c7b Compare December 4, 2024 23:26
dirgim
dirgim approved these changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@dirgim dirgim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Josh-Everett Josh-Everett force-pushed the integration_quay_reorg branch from d5e2c7b to 9397b2a Compare December 5, 2024 16:27
@Josh-Everett
Copy link
Contributor Author

Most recent update fixes some missing references to appstudio org

@Josh-Everett Josh-Everett requested a review from dirgim December 5, 2024 16:30
dirgim
dirgim previously approved these changes Dec 6, 2024
View reviewed changes
Copy link
Contributor

@dirgim dirgim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsztuka
Copy link
Contributor

jsztuka commented Dec 6, 2024

After resolving the conflicts will provide +1.
Question, do we also want to use version 1.4.9 of konflux test image?

@Josh-Everett
Copy link
Contributor Author

Hmm odd, locally those two conflicts have been resolved, will try rebasing my pr and forcing an add here

@Josh-Everett Josh-Everett force-pushed the integration_quay_reorg branch from 9397b2a to 75f836a Compare December 9, 2024 02:07
hongweiliu17
hongweiliu17 previously approved these changes Dec 9, 2024
View reviewed changes
Copy link
Contributor

@hongweiliu17 hongweiliu17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

kdudka
kdudka previously approved these changes Dec 9, 2024
View reviewed changes
dirgim
dirgim previously approved these changes Dec 9, 2024
View reviewed changes
Copy link
Contributor

@dirgim dirgim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Josh-Everett Josh-Everett force-pushed the integration_quay_reorg branch from c8b76f8 to 207c9d6 Compare December 9, 2024 16:33
@Josh-Everett
Copy link
Contributor Author

Recent update cleared some stale conflicts and moved several references to 1.4.9 (still numerous references to 1.4.8 and other versions remain that haven't been updated in main)

@Josh-Everett Josh-Everett requested a review from dirgim December 9, 2024 16:45
dirgim
dirgim approved these changes Dec 9, 2024
View reviewed changes
Copy link
Contributor

@dirgim dirgim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@Josh-Everett Josh-Everett force-pushed the integration_quay_reorg branch 2 times, most recently from b7e69e6 to b256d72 Compare December 10, 2024 12:52
@Josh-Everett Josh-Everett force-pushed the integration_quay_reorg branch 2 times, most recently from 3386636 to 1a26259 Compare December 10, 2024 14:33
@Josh-Everett
Copy link
Contributor Author

...another rebase

@Josh-Everett
feat(STONEINTG-946): migrate redhat-appstudio/konflux-test
5b0c77d 
Update references to redhat-appstudio quay repo to reflect move to
konflux-ci org. Konflux-test image v1.14 used by numerous checks
has additionally been relocated to new repo to maintain
functionality.

Signed-off-by: Josh Everett <[email protected]>
@Josh-Everett Josh-Everett force-pushed the integration_quay_reorg branch from 1a26259 to 5b0c77d Compare December 10, 2024 16:57
@kasemAlem
Copy link
Contributor

LGTM

@Josh-Everett
Copy link
Contributor Author

Hmm confused by what is blocking this merge at this point - I assumed code owners requirement would be satisfied with @arewm approval. I am wondering if it is because the tasks modified compose several different groups/sections mentioned within the CODEOWNERS and it requires an approver from each section impacted?

@arewm
Copy link
Member

arewm commented Dec 10, 2024

I assume that it requires approval from each relevant set of CODEOWNERS.

amisstea
amisstea approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@amisstea amisstea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

avi-biton
avi-biton approved these changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@avi-biton avi-biton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kasemAlem kasemAlem added this pull request to the merge queue Dec 11, 2024
Merged via the queue into konflux-ci:main with commit 0d2ac74 Dec 11, 2024
16 checks passed
@rh-tap-build-team rh-tap-build-team bot mentioned this pull request Dec 11, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avi-biton avi-biton avi-biton approved these changes

@chmeliik chmeliik chmeliik approved these changes

@dirgim dirgim dirgim approved these changes

@amisstea amisstea amisstea approved these changes

@arewm arewm arewm approved these changes

@lcarva lcarva lcarva approved these changes

@kdudka kdudka kdudka approved these changes

@14rcole 14rcole Awaiting requested review from 14rcole

@dheerajodha dheerajodha Awaiting requested review from dheerajodha

@jsztuka jsztuka Awaiting requested review from jsztuka

@jencull jencull Awaiting requested review from jencull

@chipspeak chipspeak Awaiting requested review from chipspeak

@gbenhaim gbenhaim Awaiting requested review from gbenhaim gbenhaim is a code owner

@yftacherzog yftacherzog Awaiting requested review from yftacherzog yftacherzog is a code owner

@kasemAlem kasemAlem Awaiting requested review from kasemAlem

@hongweiliu17 hongweiliu17 Awaiting requested review from hongweiliu17

@Omeramsc Omeramsc Awaiting requested review from Omeramsc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.