Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

creating component from GitLab requires 2 annotations #118

Open
jhutar opened this issue Aug 21, 2024 · 4 comments
Open

creating component from GitLab requires 2 annotations #118

jhutar opened this issue Aug 21, 2024 · 4 comments

Comments

@jhutar
Copy link
Contributor

jhutar commented Aug 21, 2024

When I attempt to on-board private component on company internal GitLab instance, I was pointed at this documentation:

https://docs.google.com/document/d/1bKE4pmrufEb1QROo7XhMVEmUClc--WtAmX1__rxNscc/edit#bookmark=id.u7p3l2ih7byb

That mentions 2 annotations that are not mentioned in Konflux docs: "git-provider" and "git-provider-url". This is a complete component YAML I have used:

apiVersion: appstudio.redhat.com/v1alpha1
kind: Component
metadata:
  annotations:
    build.appstudio.openshift.io/pipeline: '{"name":"docker-build","bundle":"latest"}'
    build.appstudio.openshift.io/request: configure-pac
    git-provider: gitlab
    git-provider-url: https://gitlab.example.com
  name: myrepo
  namespace: jhutar-tenant
spec:
  application: something
  componentName: myrepo
  resources: {}
  source:
    git:
      url: https://gitlab.example.com/something/myrepo
      context: ./
      dockerfileUrl: Containerfile
      revision: main

IMHO these two annotations should be mentioned in the docs.

@jhutar
Copy link
Contributor Author

jhutar commented Aug 21, 2024

Hello @rcerven. Just FYI.

@rcerven
Copy link
Contributor

rcerven commented Aug 21, 2024

@arewm
Copy link
Member

arewm commented Aug 21, 2024

In our documentation, we indicate the labels on the secret but not on the annotations component CR as well.

@rcerven
Copy link
Contributor

rcerven commented Aug 21, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants