fix(KONFLUX-2311): Fix PVC function in load test #1064
Conversation
|
/test ? |
|
@naftalysh: The following commands are available to trigger required jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test load-test-ci-10u-10t |
cmd/loadTests.go
Outdated
| @@ -1735,6 +1759,9 @@ func (h *ConcreteHandlerItsPipelines) validateItsPipeline(ctx *JourneyContext, a | |||
| return false, nil | |||
| } | |||
| if IntegrationTestsPipelineRun.IsDone() { | |||
| if !stage { | |||
| h.handlePVCSforITS(threadIndex, framework, IntegrationTestsPipelineRun) | |||
There was a problem hiding this comment.
This function is a duplicate of handlePVCS function and it fails SonarCloud Duplicated Lines (%) on New Code
55.6% rule
The way to allow handlePVCSto be used for both handlers - ConcreteHandlerPipelines and ConcreteHandlerItsPipelines is -
- To change the below ConcreteHandlerItsPipelines struct definition
type ConcreteHandlerItsPipelines struct {
BaseHandler
}
To
type ConcreteHandlerItsPipelines struct {
*ConcreteHandlerPipelines // Embedding ConcreteHandlerPipelines
}
2 . Update the below
h.handlePVCSforITS(threadIndex, framework, IntegrationTestsPipelineRun)
To
h.handlePVCS(threadIndex, framework, IntegrationTestsPipelineRun)
- Delete function handlePVCSforITS
There was a problem hiding this comment.
Updated the code 👍
There was a problem hiding this comment.
Hi @siddardh-ra
I found there is a change needed, I create a review
|
/test load-test-ci-10u-10t |
|
load-test-ci-10u-10t seamed to fail the load test |
|
/hold |
cmd/loadTests.go
Outdated
| @@ -1666,7 +1673,7 @@ func (h *ConcreteHandlerPipelines) handlePVCS(threadIndex int, framework *framew | |||
| } | |||
|
|
|||
| type ConcreteHandlerItsPipelines struct { | |||
| BaseHandler | |||
| *ConcreteHandlerPipelines // Embedding ConcreteHandlerPipelines | |||
There was a problem hiding this comment.
You should change it to the below to fix the struct embedding
ConcreteHandlerPipelines // Embedding ConcreteHandlerPipelines
|
/test load-test-ci-10u-10t |
|
Hi @siddardh-ra Now check it in GITHUB Action load tests workflow while pointing to your branch |
|
@siddardh-ra: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/test load-test-ci-10u-10t-nodejs |
|
/test ? |
|
@naftalysh: The following commands are available to trigger required jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: naftalysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/unhold |
|
/lgtm |
|
/test load-test-ci-10u-10t |
Update PVC function for ITS Add handling also for ITS pipelineRuns Signed-Off-By: Siddardh R A <[email protected]>
siddardh-ra
force-pushed
the
fix_pvc_stage_temp
branch
from
1b8d021 to
f4bc89d
Compare
|
|
/test load-test-ci-10u-10t |
|
/lgtm |
Update PVC function for ITS
Add handling also for ITS pipelineRuns
Signed-Off-By: Siddardh R A [email protected]
Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.
Issue ticket number and link
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: