Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove references to jvm-build-service #1478

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tnevrlka
Copy link
Contributor

Description

  • jvm-build-service is currently not being used by anyone
  • It is going to undergo major breaking changes and is going to be removed for now until the changes are done
  • Current tests are probably going to be useless due to the rewrite

Issue ticket number and link

STONEBLD-3015

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

N/A

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added meaningful description with JIRA/GitHub issue key(if applicable), for example HASSuiteDescribe("STONE-123456789 devfile source")
  • I have updated labels (if needed)

- jvm-build-service is currently not being used by anyone
- It is going to undergo major breaking changes and is going to be
  removed for now until the changes are done
- Current tests are probably going to be useless due to the rewrite
@openshift-ci openshift-ci bot requested review from jinqi7 and rcerven December 12, 2024 19:29
Copy link

openshift-ci bot commented Dec 12, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign flacatus for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tnevrlka
Copy link
Contributor Author

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant