Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Animation #7

Open
marbat87 opened this issue Aug 14, 2015 · 7 comments
Open

Animation #7

marbat87 opened this issue Aug 14, 2015 · 7 comments

Comments

@marbat87
Copy link

Hi,

Both in my testing application using your library and in your example application, the animation is not flowing.
In particular, for the left side of the toolbar (or the top of the sheet) the end of the animation is jerky.

Could you please give it a look?

Thanks in advance.
Marcello

@konifar
Copy link
Owner

konifar commented Aug 14, 2015

@marbat87 Thank you for your report.
Could you please upload your screenshot or layout xml code?

@marbat87
Copy link
Author

Hi,

my layout is below..
However I noticed:

  • I think it doens't depend on the layout, because running your app from play store on my Nexus 5 also has this behavior
  • I tried on lower android versions (4.1.1 and 4.4.4) and it seems to be working fine on this versions, so it could be an issue of the lollipop part of the code.

Thanks

<?xml version="1.0" encoding="utf-8"?>
<android.support.design.widget.CoordinatorLayout xmlns:android="http://schemas.android.com/apk/res/android"
    xmlns:risuscito="http://schemas.android.com/apk/res-auto"
    xmlns:tools="http://schemas.android.com/tools"
    android:id="@+id/main_content"
    android:layout_width="match_parent"
    android:layout_height="match_parent">
    ... content...
    <!-- Any Fab is OK. (Third party library, your custom view and so on) -->
    <android.support.design.widget.FloatingActionButton
        android:id="@+id/fab_pager"
        android:src="@drawable/ic_add_white_24dp"
        android:layout_gravity="bottom|end"
        android:layout_height="wrap_content"
        android:layout_width="wrap_content"
        android:layout_marginBottom="@dimen/fab_margin_bottom"
        android:layout_marginEnd="@dimen/fab_margin_end"
        android:layout_marginRight="@dimen/fab_margin_end"
        risuscito:elevation="@dimen/toolbar_elevation"
        risuscito:pressedTranslationZ="@dimen/fab_translation_z_pressed"
        risuscito:layout_behavior="it.cammino.risuscito.ui.ScrollAwareFABBehavior" />
    <!-- You must wrap transform view in Circular reveal container -->
    <io.codetail.widget.RevealFrameLayout
        android:layout_width="match_parent"
        android:layout_height="wrap_content"
        android:layout_gravity="bottom">
        <!-- Transform view -->
        <android.support.v7.widget.Toolbar
            android:id="@+id/toolbar_footer"
            android:layout_width="match_parent"
            android:layout_height="64dp"
            android:theme="@style/ActionBarThemeOverlay"
            risuscito:popupTheme="@style/ActionBarPopupThemeOverlay"
            android:background="?attr/colorPrimary"
            android:elevation="6dp"
            android:visibility="invisible">
            <ImageButton
                android:id="@+id/fab_delete_lista"
                android:layout_width="@dimen/abc_action_bar_default_height_material"
                android:layout_height="@dimen/abc_action_bar_default_height_material"
                android:paddingLeft="@dimen/button_playbar_padding"
                android:paddingRight="@dimen/button_playbar_padding"
                android:layout_gravity="center"
                android:scaleType="fitCenter"
                android:theme="@style/ActionBarThemeOverlay"
                android:background="?attr/customSelectorRound"
                android:src="@drawable/ic_delete_white_48dp"
                android:elevation="6dp"
                android:soundEffectsEnabled="true" />
            <ImageButton
                android:id="@+id/fab_edit_lista"
                android:layout_width="@dimen/abc_action_bar_default_height_material"
                android:layout_height="@dimen/abc_action_bar_default_height_material"
                android:paddingLeft="@dimen/button_playbar_padding"
                android:paddingRight="@dimen/button_playbar_padding"
                android:layout_gravity="center"
                android:scaleType="fitCenter"
                android:theme="@style/ActionBarThemeOverlay"
                android:background="?attr/customSelectorRound"
                android:src="@drawable/ic_create_white_48dp"
                android:elevation="6dp"
                android:soundEffectsEnabled="true" />
            <ImageButton
                android:id="@+id/fab_add_lista"
                android:layout_width="@dimen/abc_action_bar_default_height_material"
                android:layout_height="@dimen/abc_action_bar_default_height_material"
                android:paddingLeft="@dimen/button_playbar_padding"
                android:paddingRight="@dimen/button_playbar_padding"
                android:layout_gravity="center"
                android:scaleType="fitCenter"
                android:theme="@style/ActionBarThemeOverlay"
                android:background="?attr/customSelectorRound"
                android:src="@drawable/ic_add_white_48dp"
                android:elevation="6dp"
                android:soundEffectsEnabled="true" />
            <ImageButton
                android:id="@+id/fab_pulisci"
                android:layout_width="@dimen/abc_action_bar_default_height_material"
                android:layout_height="@dimen/abc_action_bar_default_height_material"
                android:paddingLeft="@dimen/button_playbar_padding"
                android:paddingRight="@dimen/button_playbar_padding"
                android:layout_gravity="center"
                android:scaleType="fitCenter"
                android:theme="@style/ActionBarThemeOverlay"
                android:background="?attr/customSelectorRound"
                android:src="@drawable/ic_eraser_white_48dp"
                android:elevation="6dp"
                android:soundEffectsEnabled="true" />
        </android.support.v7.widget.Toolbar>
    </io.codetail.widget.RevealFrameLayout>
</android.support.design.widget.CoordinatorLayout>

@konifar
Copy link
Owner

konifar commented Aug 14, 2015

@marbat87
Thanks for your good research. As you said, it seems to be a bug on Lollipop version.
I'll check my sample and library code.

@abbasalim
Copy link

yes , this is in lollipop , please fix bug , thanks

@juliocbcotta
Copy link

any update on this?

@davideas
Copy link

This library (https://github.com/bowyer-app/fab-toolbar) doesn't seem to have that bug, and it is on Lollipop as well.
Maybe a refresh of the library removing also NineOld could be a good idea.

@nikhilpanju
Copy link

Is there any way to rectify this? It's very unpleasing for bigger views
@marbat87 @konifar @davideas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants