-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 address performance issue with perl #751
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pranavgaikwad
force-pushed
the
fixPerlCommand
branch
from
December 13, 2024 18:10
949eb81
to
844a8ca
Compare
shawn-hurley
approved these changes
Dec 13, 2024
Note: demo image is failing to build because latest gopls needs go 1.23, I have that fixed in my other PR. will rebase when that's in |
eemcmullan
approved these changes
Dec 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on MacOS - ty for the fix
Signed-off-by: Pranav Gaikwad <[email protected]>
pranavgaikwad
force-pushed
the
fixPerlCommand
branch
2 times, most recently
from
December 13, 2024 19:14
7c93fad
to
7e31ab0
Compare
Signed-off-by: Pranav Gaikwad <[email protected]> Signed-off-by: Pranav Gaikwad <[email protected]>
pranavgaikwad
force-pushed
the
fixPerlCommand
branch
from
December 13, 2024 19:28
7e31ab0
to
0ca9e58
Compare
Signed-off-by: Pranav Gaikwad <[email protected]>
shawn-hurley
approved these changes
Dec 13, 2024
aufi
approved these changes
Dec 16, 2024
dymurray
added
the
cherry-pick/release-0.6
This PR should be cherry-picked to release-0.6 branch
label
Dec 16, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Dec 16, 2024
Signed-off-by: Pranav Gaikwad <[email protected]> Signed-off-by: Cherry Picker <[email protected]>
dymurray
pushed a commit
that referenced
this pull request
Dec 16, 2024
Signed-off-by: Pranav Gaikwad <[email protected]> Signed-off-by: Cherry Picker <[email protected]> Signed-off-by: Pranav Gaikwad <[email protected]> Signed-off-by: Cherry Picker <[email protected]> Co-authored-by: Pranav Gaikwad <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.