Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[client] need initialize|shutdown|exit #64

Open
djzager opened this issue Oct 16, 2024 · 0 comments
Open

[client] need initialize|shutdown|exit #64

djzager opened this issue Oct 16, 2024 · 0 comments
Assignees
@hhpatel14
Milestone
Milestone #3

Comments

@djzager
Copy link
Member

djzager commented Oct 16, 2024 •
edited
Loading

This depends on konveyor/kai#433 because, once implemented, we will need our client to implement the matching methods.

This also depends on #62 , whether we are communicating with the kai/rpc-server or the analyzer dictates the InitializeParams that we send over the wire. kai/rpc-server will require MORE details (the kai/rpc-server pieces + path to analyzer + analyzer specific args)

Definition of Done:

  • Start and runAnalysis functions are updated in the analyzerClient to handle changes in Refactor kai-analyzer kai#433
  • New functions are implemented to handle initialize, shutdown, and exit
  • assets/bin are updated with kai-analyzer binaries.
@djzager djzager mentioned this issue Oct 16, 2024
Open
@hhpatel14 hhpatel14 self-assigned this Oct 31, 2024
@djzager djzager mentioned this issue Nov 7, 2024
Merged
hhpatel14 added a commit that referenced this issue Nov 8, 2024
@hhpatel14
✨ Start kai/rpc-server (#81)
d5bac40 
- Add kai-rpc server Path property which user can override


Fixes #62 #64 

<!--
## PR Title Prefix

Every **PR Title** should be prefixed with :text: to indicate its type.

- Breaking change: ⚠️ (`⚠️`)
- Non-breaking feature: ✨ (`✨`)
- Patch fix: 🐛 (`🐛`)
- Docs: 📖 (`📖`)
- Infra/Tests/Other: 🌱 (`🌱`)
- No release note: 👻 (`👻`)

For example, a pull request containing breaking changes might look like
`⚠️ My pull request contains breaking changes`.

Since GitHub supports emoji aliases (ie. `👻`), there is no need to
include
the emoji directly in the PR title -- **please use the alias**. It used
to be
the case that projects using emojis for PR typing had to include the
emoji
directly because GitHub didn't render the alias. Given that `⚠️`
is
easy enough to read as text, easy to parse in release tooling, and
rendered in
GitHub well, we prefer to standardize on the alias.

For more information, please see the Konveyor
[Versioning
Doc](https://github.com/konveyor/release-tools/blob/main/VERSIONING.md).
-->

---------

Signed-off-by: hhpatel14 <[email protected]>
@dymurray dymurray added this to the Milestone #3 milestone Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hhpatel14 hhpatel14

Labels
None yet
Projects
None yet
Milestone
Milestone #3
Development

No branches or pull requests
3 participants
@djzager @dymurray @hhpatel14