Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix METHOD_CALL location in queryQualificationMatches #108

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

jmle
Copy link
Collaborator

@jmle jmle commented Aug 26, 2024

Should fix konveyor/analyzer-lsp#693

System.out.println will never match because out is a static field that references another class (java.io.PrintStream), but this should fix the rest of the cases.

@shawn-hurley
Copy link
Contributor

What happens when you have something liek java.*.nio.getPaths() where the star should match? should this be a regex match rather than starts with?

@pranavgaikwad
Copy link
Contributor

matches() check on Line 218 should do what Shawn is asking for, I think this is a different input

@jmle jmle merged commit e6b7314 into konveyor:main Aug 26, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] [RULES] Cannot match System.out.println with anything mores specifc than pattern: "System*"
3 participants