Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix exec_args for execvp #118

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jmontleon
Copy link
Member

I realize the goal is to get rid of this script, so no issue if we don't want to bother merging this. But the first arg for execvp is supposed to be the command itself.

Signed-off-by: Jason Montleon <[email protected]>
@jmontleon
Copy link
Member Author

Instead of

user         878     876  1 12:49 ?        00:00:15 java-external-provider --port 14651 --port=50094
user         979     878  6 12:50 ?        00:01:32 -Declipse.application=org.eclipse.jdt.ls.core.id1 -Dosgi.bundles.defaultStartLevel=4 -Declipse.product=org.eclipse.jdt.ls.core.product -Dosgi.checkConfiguration=true -Dosgi.sharedConfiguration.area=/jdtls/config_linux -Dosgi.sharedConfiguration.area.readOnly=true -Dosgi.configuration.cascaded=true -Xms1g -XX:MaxRAMPercentage=70.0 --add-modules=ALL-SYSTEM --add-opens java.base/java.util=ALL-UNNAMED --add-opens java.base/java.lang=ALL-UNNAMED -jar /jdtls/plugins/org.eclipse.equinox.launcher_1.6.900.v20240613-2009.jar -data  -Djava.net.useSystemProxies=true -configuration ./

It now shows:

user        5254    5252  6 14:27 ?        00:00:11 java-external-provider --port 14651 --port=50496
user        5366    5254 21 14:27 ?        00:00:29 /usr/lib/jvm/java-17-openjdk-17.0.13.0.11-4.el9.x86_64/bin/java -Declipse.application=org.eclipse.jdt.ls.core.id1 -Dosgi.bundles.defaultStartLevel=4 -Declipse.product=org.eclipse.jdt.ls.core.product -Dosgi.checkConfiguration=true -Dosgi.sharedConfiguration.area=/jdtls/config_linux -Dosgi.sharedConfiguration.area.readOnly=true -Dosgi.configuration.cascaded=true -Xms1g -XX:MaxRAMPercentage=70.0 --add-modules=ALL-SYSTEM --add-opens java.base/java.util=ALL-UNNAMED --add-opens java.base/java.lang=ALL-UNNAMED -jar /jdtls/plugins/org.eclipse.equinox.launcher_1.6.900.v20240613-2009.jar -data  -Djava.net.useSystemProxies=true -configuration ./

Copy link
Member

@aufi aufi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks OK, just linking PR with jdtls startup change replcing this script functionality konveyor/analyzer-lsp#749

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants